typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore(eslint-plugin): use defs, not definitions, in rule schemas#5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:defs-not-definition

Aug 24, 2022

Merged

chore(eslint-plugin): use defs, not definitions, in rule schemas#5534

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromJoshuaKGoldberg:defs-not-definition

Aug 24, 2022

Conversation

Copy link

Member

JoshuaKGoldberg commentedAug 23, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: Migrate json-schema from deprecated $definitions to $defs #5509
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Does a find-and-replace per the issue:definitions ->$defs.

chore(eslint-plugin): use , not definitions, in rule schemas

082e18f

Copy link

nx-cloudbot commentedAug 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit230f212. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedAug 23, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedAug 23, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`230f212`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/630620021309270009c7f9e0
😎 Deploy Preview	https://deploy-preview-5534--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedAug 23, 2022•
edited
Loading

Codecov Report

Merging#5534 (082e18f) intomain (6ab767b) willincrease coverage by2.34%.
The diff coverage isn/a.

❗ Current head082e18f differs from pull request most recent head230f212. Consider uploading reports for the commit230f212 to get more accurate results

@@            Coverage Diff             @@##             main    #5534      +/-   ##==========================================+ Coverage   91.57%   93.92%   +2.34%==========================================  Files         132      290     +158       Lines        1496    10017    +8521       Branches      226     3016    +2790     ==========================================+ Hits         1370     9408    +8038- Misses         62      330     +268- Partials       64      279     +215

Flag	Coverage Δ
unittest	`93.92% <ø> (+2.34%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts	`97.14% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`96.96% <ø> (ø)`
packages/eslint-plugin/src/rules/comma-dangle.ts	`93.33% <ø> (ø)`
...-plugin/src/rules/explicit-member-accessibility.ts	`97.18% <ø> (ø)`
...lugin/src/rules/padding-line-between-statements.ts	`93.83% <ø> (ø)`
...es/eslint-plugin/src/rules/parameter-properties.ts	`94.11% <ø> (ø)`
...nt-plugin/src/rules/space-before-function-paren.ts	`100.00% <0.00%> (ø)`
...es/eslint-plugin/src/rules/no-array-constructor.ts	`100.00% <0.00%> (ø)`
...t-plugin/src/rules/adjacent-overload-signatures.ts	`95.34% <0.00%> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`88.88% <0.00%> (ø)`
... and154 more

JoshuaKGoldberg changed the title~~chore(eslint-plugin): use , not definitions, in rule schemas~~chore(eslint-plugin): use defs, not definitions, in rule schemas

Aug 23, 2022

JoshuaKGoldberg marked this pull request as ready for review

August 23, 2022 20:16