Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fail tests that log to the console#5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedAug 23, 2022•
edited
Loading

PR Checklist

Overview

Usesconsole-fail-test to fail tests that call toconsole.log,console.warn, etc.

Marking as ready to review because it is, though merging is blocked on#5531.

Example in CI:

Screenshot of ban-ts-comment.test.ts in GitHub Actions with console-fail-tests complaints about failing tests

jakebailey reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedAug 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit875ac1f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedAug 23, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit875ac1f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/630688be5468340008ff6318
😎 Deploy Previewhttps://deploy-preview-5533--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacher
Copy link
Member

Eyyy the tests are failing like they should

JoshuaKGoldberg reacted with rocket emoji

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewAugust 23, 2022 15:13
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

@bradzacherbradzacher merged commita315daa intotypescript-eslint:mainAug 25, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the console-fail-test branchAugust 25, 2022 02:25
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Fail tests on console logs
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp