Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(scope-manager): visit static blocks#5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

DMartens
Copy link
Contributor

PR Checklist

Overview

Only added the visitor for static blocks for classes as the scope was already present.

@nx-cloud
Copy link

nx-cloudbot commentedAug 16, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6c98e88. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@DMartens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedAug 16, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6c98e88
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62fb76a0bb98070009593081
😎 Deploy Previewhttps://deploy-preview-5489--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedAug 16, 2022
edited
Loading

Codecov Report

Merging#5489 (6c98e88) intomain (830b946) willdecrease coverage by0.12%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #5489      +/-   ##==========================================- Coverage   91.74%   91.61%   -0.13%==========================================  Files         366      347      -19       Lines       12344    10929    -1415       Branches     3601     3220     -381     ==========================================- Hits        11325    10013    -1312+ Misses        668      592      -76+ Partials      351      324      -27
FlagCoverage Δ
unittest91.61% <100.00%> (-0.13%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...s/scope-manager/src/scope/ClassStaticBlockScope.ts100.00% <ø> (+25.00%)⬆️
...kages/scope-manager/src/referencer/ClassVisitor.ts94.11% <100.00%> (+0.10%)⬆️
packages/typescript-estree/src/ts-estree/index.ts
...ges/typescript-estree/src/create-program/shared.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/simple-traverse.ts
...ript-estree/src/create-program/createSourceFile.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/convert-comments.ts
packages/visitor-keys/src/get-keys.ts
... and13 more

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

I'm still pretty new to this area so we should let another maintainer approve. But this seems pretty straightforward 😄

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelAug 16, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oops - looks like this was supposed to be actioned in#4211 but the visitor wasn't added.

thanks for thsi!

@bradzacherbradzacher changed the titlefeat(scope-manager): visit static blocksfix(scope-manager): visit static blocksAug 17, 2022
@bradzacherbradzacher added the bugSomething isn't working labelAug 17, 2022
@bradzacherbradzacher merged commit78745c2 intotypescript-eslint:mainAug 17, 2022
@DMartensDMartens deleted the scope-manager-static-block branchAugust 17, 2022 09:15
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [scope-manager] Static Blocks do not introduce a scope
3 participants
@DMartens@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp