Aug 16, 2022 · Aug 9, 2022 · Aug 9, 2022 · Aug 15, 2022 · Aug 16, 2022 · Aug 9, 2022
diff --git a/packages/eslint-plugin/src/rules/no-useless-constructor.ts b/packages/eslint-plugin/src/rules/no-useless-constructor.ts
 }

 /**
 * Check if method is notunless due to typescript parameter properties
 * Check if method is notuseless due to typescript parameter properties and decorators
 */
 function checkParams(node: TSESTree.MethodDefinition): boolean {
  return (
    !node.value.params ||
    !node.value.params.some(
      param => param.type === AST_NODE_TYPES.TSParameterProperty,
      param =>
        param.type === AST_NODE_TYPES.TSParameterProperty ||
        param.decorators?.length,
    )
  );
 }
diff --git a/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts b/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
    `
 class A {
  constructor(foo);
 }
    `,
    `
 class A extends Object {
  constructor(@Foo foo: string) {
    super(foo);
  }
 }
    `,
    `
 class A extends Object {
  constructor(foo: string, @Bar() bar) {
    super(foo, bar);
  }
 }
    `,
  ],
Original file line number	Diff line number	Diff line change
Expand Up		@@ -31,13 +31,15 @@ function checkAccessibility(node: TSESTree.MethodDefinition): boolean {
		}

		/**
		* Check if method is notunless due to typescript parameter properties
		* Check if method is notuseless due to typescript parameter properties and decorators
		*/
		function checkParams(node: TSESTree.MethodDefinition): boolean {
		return (
		!node.value.params \|\|
		!node.value.params.some(
		param => param.type === AST_NODE_TYPES.TSParameterProperty,
		param =>
		param.type === AST_NODE_TYPES.TSParameterProperty \|\|
		param.decorators?.length,
Copy link Member JoshuaKGoldbergAug 9, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Aside: it might be the case that`param.decorators` would make sense as a check, as it might be that the parser doesn't create`param.decorators` if it would have length 0. But that's a nuance not yet strongly defined in AST parsing.#5020
		)
		);
		}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -206,6 +206,20 @@ class A extends B {
		`
		class A {
		constructor(foo);
		}
		`,
		`
		class A extends Object {
		constructor(@Foo foo: string) {
		super(foo);
		}
		}
		`,
		`
		class A extends Object {
		constructor(foo: string, @Bar() bar) {
		super(foo, bar);
		}
		}
		`,
		],
Expand Down