typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [no-extra-parens] handle await with type assertion#5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/#5124

Aug 7, 2022

Merged

fix(eslint-plugin): [no-extra-parens] handle await with type assertion#5428

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/#5124

Aug 7, 2022

Conversation

Copy link

Contributor

yeonjuan commentedAug 6, 2022

PR Checklist

Addresses an existing open issue:fixesBug: [no-extra-parens] incorrect precedence for await vs assertion #5124
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

fix(eslint-plugin): [no-extra-parens] handle await with type assertion

f07d785

Copy link

Contributor

typescript-eslintbot commentedAug 6, 2022

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

nx-cloudbot commentedAug 6, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitab6fad3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedAug 6, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ab6fad3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62efc78aa29f140008af91be
😎 Deploy Preview	https://deploy-preview-5428--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedAug 6, 2022•
edited
Loading

Codecov Report

Merging#5428 (dc3656d) intomain (df4e05e) willincrease coverage by2.46%.
The diff coverage is100.00%.

❗ Current headdc3656d differs from pull request most recent headab6fad3. Consider uploading reports for the commitab6fad3 to get more accurate results

@@            Coverage Diff             @@##             main    #5428      +/-   ##==========================================+ Coverage   91.36%   93.83%   +2.46%==========================================  Files         132      290     +158       Lines        1494     9988    +8494       Branches      226     3006    +2780     ==========================================+ Hits         1365     9372    +8007- Misses         65      335     +270- Partials       64      281     +217

Flag	Coverage Δ
unittest	`93.83% <100.00%> (+2.46%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	`90.78% <100.00%> (ø)`
...ages/eslint-plugin/src/rules/default-param-last.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`100.00% <0.00%> (ø)`
.../eslint-plugin/src/rules/no-useless-constructor.ts	`95.23% <0.00%> (ø)`
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	`95.00% <0.00%> (ø)`
packages/eslint-plugin/src/configs/base.ts	`100.00% <0.00%> (ø)`
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts	`75.00% <0.00%> (ø)`
...plugin/src/rules/naming-convention-utils/shared.ts	`100.00% <0.00%> (ø)`
...t-plugin/src/rules/class-literal-property-style.ts	`100.00% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-var-requires.ts	`90.00% <0.00%> (ø)`
... and149 more

JoshuaKGoldberg requested changes

Aug 6, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code change seems reasonable, thanks for sending it in! A couple of nits, but mostly requesting changes on filling in the missing test coverage. ✨

packages/eslint-plugin/src/rules/no-extra-parens.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-extra-parens.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Aug 6, 2022

apply review

dc3656d

yeonjuan requested a review fromJoshuaKGoldberg

August 7, 2022 10:59

Copy link

ContributorAuthor

yeonjuan commentedAug 7, 2022

@JoshuaKGoldberg Thanks for the review 👍

JoshuaKGoldberg approved these changes

Aug 7, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks!

JoshuaKGoldbergenabled auto-merge (squash)

August 7, 2022 13:54

Merge branch 'main' into fix/typescript-eslint#5124

ab6fad3

JoshuaKGoldberg merged commite03826f intotypescript-eslint:main

Aug 7, 2022

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Aug 9, 2022

Update typescript-eslint monorepo to v5.33.0 (#1494)

6e51437

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.32.0/5.33.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.32.0/5.33.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)##### Bug Fixes-   **eslint-plugin:** \[no-extra-parens] handle await with type assertion ([#&#8203;5428](typescript-eslint/typescript-eslint#5428)) ([e03826f](typescript-eslint/typescript-eslint@e03826f))-   **website:** add explicit frontmatter description to rule docs ([#&#8203;5429](typescript-eslint/typescript-eslint#5429)) ([63cba5f](typescript-eslint/typescript-eslint@63cba5f))##### Features-   **eslint-plugin:** \[member-ordering] support static blocks ([#&#8203;5417](typescript-eslint/typescript-eslint#5417)) ([5983e5a](typescript-eslint/typescript-eslint@5983e5a))-   **eslint-plugin:** \[prefer-as-const] adds support for class properties ([#&#8203;5413](typescript-eslint/typescript-eslint#5413)) ([d2394f8](typescript-eslint/typescript-eslint@d2394f8))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE1MS4yIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1494Reviewed-by: 6543 <6543@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actionsbot locked asresolvedand limited conversation to collaborators

Sep 7, 2022

Labels

awaiting response

Issues waiting for a reply from the OP or another party

2 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-extra-parens] handle await with type assertion#5428

fix(eslint-plugin): [no-extra-parens] handle await with type assertion#5428

Uh oh!

Conversation

yeonjuan commentedAug 6, 2022

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedAug 6, 2022

Uh oh!

nx-cloudbot commentedAug 6, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

netlifybot commentedAug 6, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedAug 6, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedAug 7, 2022

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nx-cloudbot commentedAug 6, 2022•
edited
Loading

netlifybot commentedAug 6, 2022•
edited
Loading

codecovbot commentedAug 6, 2022•
edited
Loading