Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: rename typeParameters to typeArguments where needed#5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 26, 2022•
edited
Loading

BREAKING CHANGE:
Adds duplicate properties on the AST and deprecates their old names

PR Checklist

Overview

RenamestypeParameters totypeArguments in locations that are indeed providing typearguments.

To recap the terminology:

  • Anargument is something you provide to a recipient, such as a type provided explicitly to a call expression
  • Aparameter is how the recipient receives what you provide, such as a function declaration's generic type parameter

Marked as a breaking change even though the old, now-@deprecated property is still there.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedJul 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit627a883. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx run-many --target=lint --parallel
✅ Successfully ran 50 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedJul 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit627a883
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63f7061a0a1f550008a8517d
😎 Deploy Previewhttps://deploy-preview-5384--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg added the breaking changeThis change will require a new major version to be released labelJul 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the correct-type-parameters-to-arguments branchJuly 26, 2022 01:19
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg restored the correct-type-parameters-to-arguments branchFebruary 5, 2023 05:47
@JoshuaKGoldbergJoshuaKGoldbergforce-pushed thecorrect-type-parameters-to-arguments branch from2cc8461 to6573aa0CompareFebruary 5, 2023 06:02
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 5, 2023 06:26
@JoshuaKGoldbergJoshuaKGoldberg added this to the6.0.0 milestoneFeb 5, 2023
@bradzacher
Copy link
Member

Thinking about this in terms of the broader ecosystem and the impacts - I wonder if we want to give consumers one major version to migrate?
A hard cut over might be a bit difficult for the ecosystem to come handle as it would involve every single plugin updating their code (which could leave users in an impossible to upgrade state for some time).

How about this: this version we add the new property and we mark the old property as@deprecated, then in v7 we remove the old property entirely.

If we wanted we could also do something like define a getter that throws when in a test environment to help flag plugins that they should migrate.

WDYT?

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6February 7, 2023 17:03
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedFeb 7, 2023•
edited
Loading

Yeah that makes sense. I'll put the@deprecated old properties in this PR (once I get the new ones working)

The process env check + getter idea is really nifty - seems like a good followup feature request. I'd like to get it in v6... thinking 🤔

@typescript-eslinttypescript-eslint unlocked this conversationFeb 7, 2023
@codecov
Copy link

codecovbot commentedFeb 10, 2023•
edited
Loading

Codecov Report

Merging#5384 (627a883) intov6 (d676683) willnot change coverage.
The diff coverage is72.50%.

Additional details and impacted files
@@           Coverage Diff           @@##               v6    #5384   +/-   ##=======================================  Coverage   87.06%   87.06%           =======================================  Files         365      365             Lines       12579    12579             Branches     3720     3720           =======================================  Hits        10952    10952             Misses       1278     1278             Partials      349      349
FlagCoverage Δ
unittest87.06% <72.50%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...es/eslint-plugin/src/rules/no-array-constructor.ts100.00% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts95.83% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts100.00% <ø> (ø)
packages/type-utils/src/isUnsafeAssignment.ts84.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts28.20% <18.18%> (ø)
packages/eslint-plugin/src/rules/array-type.ts97.14% <100.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts100.00% <100.00%> (ø)
...lugin/src/rules/consistent-generic-constructors.ts90.69% <100.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts92.06% <100.00%> (ø)
... and9 more

@bradzacherbradzacher changed the titlefix!: rename typeParameters to typeArguments where neededfix: rename typeParameters to typeArguments where neededFeb 13, 2023
@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 13, 2023
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 20, 2023
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah that makes sense. I'll put the@deprecated old properties in this PR (once I get the new ones working)

Once we've got this change, this is good-to-go I think.

JoshuaKGoldberg reacted with thumbs up emoji
@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 20, 2023
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftFebruary 21, 2023 03:45
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedFeb 21, 2023•
edited
Loading

I think the lint & integration test failures are unrelated to this PR. Indeed, they were ✅

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 21, 2023 20:45
@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 22, 2023
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftFebruary 23, 2023 06:09
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 23, 2023 06:25
@JoshuaKGoldbergJoshuaKGoldberg merged commit08d757b intotypescript-eslint:v6Feb 23, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the correct-type-parameters-to-arguments branchFebruary 23, 2023 07:02
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherAwaiting requested review from bradzacher

@armano2armano2Awaiting requested review from armano2

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Some properties named typeParameters instead of typeArguments
3 participants
@JoshuaKGoldberg@bradzacher@armano2
[8]ページ先頭
©2009-2025 Movatter.jp