Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): remove valid-typeof disable in eslint-recommended#5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 25, 2022•
edited by bradzacher
Loading

BREAKING CHANGE:
Removes the'valid-typeof': 'off' line fromeslint-recommended.ts, as it's not always covered by TypeScript.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedJul 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitffb7f09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 24 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedJul 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitffb7f09
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635838212f3409000842f463
😎 Deploy Previewhttps://deploy-preview-5381--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg added package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin breaking changeThis change will require a new major version to be released labelsJul 25, 2022
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJuly 25, 2022 23:22
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): remove valid-typeof disable in eslint-recommendedfix!(eslint-plugin): remove valid-typeof disable in eslint-recommendedJul 25, 2022
@bradzacherbradzacher changed the titlefix!(eslint-plugin): remove valid-typeof disable in eslint-recommendedfix(eslint-plugin): remove valid-typeof disable in eslint-recommendedAug 6, 2022
@bradzacherbradzacher added this to the6.0.0 milestoneAug 6, 2022
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6October 25, 2022 21:16
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 26, 2022
@JoshuaKGoldberg
Copy link
MemberAuthor

Website CI tests failed to download fromazure.archive.ubuntu.com. New flake I've never seen before.

Get:138 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libopengl0 amd64 1.3.2-1~ubuntu0.20.04.2 [29.2 kB]Fetched 71.3 MB in 14min 51s (80.0 kB/s)E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/g/gupnp-igd/libgupnp-igd-1.0-4_0.2.5-5_amd64.deb  Connection failed [IP: 52.252.75.106 80]E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?Failed to install browsersError: Installation process exited with code: 100

@JoshuaKGoldbergJoshuaKGoldberg merged commitb90e7c3 intotypescript-eslint:v6Oct 26, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be releasedpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[valid-typeof] @typescript-eslint/recommended disables valid-typeof but it shouldn't
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp