☁️ Nx Cloud Report

CI is running/has finished running commands for commitb539c32. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	b539c32
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6306060c179228000876efed
😎 Deploy Preview	https://deploy-preview-5377--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

The errors are because Babel now treats named imports withtype: "json" as early syntax error (same problem in#5371). I don't know how we should fix this (ideally tighten our own parser), but that should be in a separate PR before this gets merged.

why did bumping the docusaurus version break theast-spec tests?
shouldn't the version ranges be independent?

for the lint errors - you should be able to convert the "bad" cases to not use prettier by adding a template tag:

code: 'test',// becomescode: noFormat`test`,

shouldn't the version ranges be independent?

It's because Docusaurus depends on the newest version of Babel and it gets deduplicated.

Didn't see the lint errors, will fix those

Does docusaurus have a peer dep on babel?
Can we pin our local version of babel so that we can upgrade them independently?

No—it's a hard dep. This can wait a bit so we can fix the parser first.

About the Babel alignment issue, this is being asked here:tc39/proposal-json-modules#27 maybe it will eventually be a non-problem.

To make this all easier to manage - we'll merge#5491 first so that we have the autoformatting merged and we can update all other PRs at our own pace, then we can review the docusaurus changes in isolation and merge without trying to keep this PR up-to-date with main.

to fix the test failure - you should just move thetest folder intothe folder called_error_.

then i reckon this is good to go?

Might want to make it a separate PR, but anyway, here it is.

sorry - I probably should have mentioned you'll need to re-run the test to update the fixtures:

$cd packages/ast-spec$ yarn jest tests/fixtures.test.ts -u

Codecov Report

Merging#5377 (b539c32) intomain (9c3e58a) willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5377      +/-   ##==========================================- Coverage   91.74%   91.74%   -0.01%==========================================  Files         366      364       -2       Lines       12373    12366       -7       Branches     3611     3611              ==========================================- Hits        11352    11345       -7  Misses        669      669                Partials      352      352

Flags with carried forward coverage won't be shown.Click here to find out more.