Jul 18, 2022 · Jul 13, 2022 · Jul 14, 2022 · Jul 13, 2022 · Jul 14, 2022 · Jul 14, 2022
diff --git a/packages/eslint-plugin/src/rules/no-inferrable-types.ts b/packages/eslint-plugin/src/rules/no-inferrable-types.ts
    },
  ],
  create(context, [{ ignoreParameters, ignoreProperties }]) {
    const sourceCode = context.getSourceCode();

    function isFunctionCall(
      init: TSESTree.Expression,
      callName: string,
        data: {
          type,
        },
        fix: fixer => fixer.remove(typeNode),
        *fix(fixer) {
          if (
            (node.type === AST_NODE_TYPES.AssignmentPattern &&
              node.left.optional) ||
            (node.type === AST_NODE_TYPES.PropertyDefinition && node.definite)
          ) {
            yield fixer.remove(sourceCode.getTokenBefore(typeNode)!);
          }
          yield fixer.remove(typeNode);
        },
      });
    }

diff --git a/packages/eslint-plugin/tests/rules/no-inferrable-types.test.ts b/packages/eslint-plugin/tests/rules/no-inferrable-types.test.ts

  invalid: [
    ...invalidTestCases,

    {
      // This is invalid TS semantic, but it's trivial to make valid anyway
      code: 'const fn = (a?: number = 5) => {};',
      output: 'const fn = (a = 5) => {};',
      options: [
        {
          ignoreParameters: false,
        },
      ],
      errors: [
        {
          messageId: 'noInferrableType',
          data: {
            type: 'number',
          },
          line: 1,
          column: 13,
        },
      ],
    },
    {
      // This is invalid TS semantic, but it's trivial to make valid anyway
      code: `
 class A {
  a!: number = 1;
 }
      `,
      output: `
 class A {
  a = 1;
 }
      `,
      options: [
        {
          ignoreProperties: false,
        },
      ],
      errors: [
        {
          messageId: 'noInferrableType',
          data: {
            type: 'number',
          },
          line: 3,
          column: 3,
        },
      ],
    },
    {
      code: "const fn = (a: number = 5, b: boolean = true, c: string = 'foo') => {};",
      output: "const fn = (a = 5, b = true, c = 'foo') => {};",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -46,6 +46,8 @@ export default util.createRule<Options, MessageIds>({
		},
		],
		create(context, [{ ignoreParameters, ignoreProperties }]) {
		const sourceCode = context.getSourceCode();

		function isFunctionCall(
		init: TSESTree.Expression,
		callName: string,
Expand DownExpand Up		@@ -215,7 +217,16 @@ export default util.createRule<Options, MessageIds>({
		data: {
		type,
		},
		fix: fixer => fixer.remove(typeNode),
		*fix(fixer) {
		if (
		(node.type === AST_NODE_TYPES.AssignmentPattern &&
		node.left.optional) \|\|
		(node.type === AST_NODE_TYPES.PropertyDefinition && node.definite)
		) {
		yield fixer.remove(sourceCode.getTokenBefore(typeNode)!);
		}
		yield fixer.remove(typeNode);
		},
		});
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -156,7 +156,54 @@ class Foo {

		invalid: [
		...invalidTestCases,

		{
		// This is invalid TS semantic, but it's trivial to make valid anyway
		code: 'const fn = (a?: number = 5) => {};',
Copy link Collaborator armano2Jul 13, 2022• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. not sure if we want to handle this in here, but there is one more use case that is broken. playground classTest{x!:number=5abstracty!:number=5} maybe something like this could be better: if(node.type===AST_NODE_TYPES.AssignmentPattern&&node.left.optional){yieldfixer.remove(sourceCode.getTokenBefore(typeNode)!);}elseif((node.type===AST_NODE_TYPES.TSAbstractPropertyDefinition\|\|node.type===AST_NODE_TYPES.PropertyDefinition)&&node.definite){yieldfixer.remove(sourceCode.getTokenBefore(typeNode)!);} we can make separate ticket for this, if you like there is also classTest2{constructor(privatea:number=5){}} witch is currently not reported Copy link MemberAuthor Josh-CenaJul 14, 2022• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'll add definite assignment to this PR, but the`private` one seems tangential to this. Does this one also seem worth reporting? classTest2{x?:number=5;} Copy link MemberAuthor Josh-CenaJul 14, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Also, the`abstract y!: number = 5` is too messed up to be autofixed. The initializer needs to be removed as well. It isn't even reported by the rule under the status quo, so I'll just ignore that.
		output: 'const fn = (a = 5) => {};',
		options: [
		{
		ignoreParameters: false,
		},
		],
		errors: [
		{
		messageId: 'noInferrableType',
		data: {
		type: 'number',
		},
		line: 1,
		column: 13,
		},
		],
		},
		{
		// This is invalid TS semantic, but it's trivial to make valid anyway
		code: `
		class A {
		a!: number = 1;
		}
		`,
		output: `
		class A {
		a = 1;
		}
		`,
		options: [
		{
		ignoreProperties: false,
		},
		],
		errors: [
		{
		messageId: 'noInferrableType',
		data: {
		type: 'number',
		},
		line: 3,
		column: 3,
		},
		],
		},
		{
		code: "const fn = (a: number = 5, b: boolean = true, c: string = 'foo') => {};",
		output: "const fn = (a = 5, b = true, c = 'foo') => {};",
Expand Down