Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): add current version of typescript to playground dropdown#5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

armano2
Copy link
Collaborator

PR Checklist

Overview

lock typescript version dropdown while playground is loading and add currently loaded ts version to dropdown

@armano2armano2 added bugSomething isn't working website: playground labelsJul 12, 2022
@nx-cloud
Copy link

nx-cloudbot commentedJul 12, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit26a9ea4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJul 12, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit26a9ea4
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62d2e46a4cad2c000957251a
😎 Deploy Previewhttps://deploy-preview-5341--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 changed the titlechore(website): add current version of typescript to dropdownchore(website): add current version of typescript to playground dropdownJul 12, 2022
@codecov
Copy link

codecovbot commentedJul 16, 2022
edited
Loading

Codecov Report

Merging#5341 (26a9ea4) intomain (4138b0d) willdecrease coverage by0.32%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5341      +/-   ##==========================================- Coverage   91.67%   91.34%   -0.33%==========================================  Files         363      132     -231       Lines       12227     1491   -10736       Branches     3549      226    -3323     ==========================================- Hits        11209     1362    -9847+ Misses        668       65     -603+ Partials      350       64     -286
FlagCoverage Δ
unittest91.34% <ø> (-0.33%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/no-redeclare.ts
packages/eslint-plugin/src/rules/indent.ts
packages/utils/src/ts-eslint/RuleTester.ts
.../eslint-plugin/src/rules/restrict-plus-operands.ts
.../eslint-plugin/src/rules/no-useless-constructor.ts
...eslint-plugin/src/rules/no-useless-empty-export.ts
...escript-estree/src/create-program/getScriptKind.ts
...ges/eslint-plugin/src/rules/space-before-blocks.ts
...es/eslint-plugin/src/util/getOperatorPrecedence.ts
...-plugin/src/rules/explicit-member-accessibility.ts
... and221 more

@armano2armano2 added the package: websiteIssues related to the @typescript-eslint website labelJul 20, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥

@bradzacherbradzacher merged commita0d5a70 intomainJul 22, 2022
@bradzacherbradzacher deleted the fix/website-add-current-ts-version-to-options-5244 branchJuly 22, 2022 18:07
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
bugSomething isn't workingpackage: websiteIssues related to the @typescript-eslint websitewebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: wrong typescript version displayed in the playground
3 participants
@armano2@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp