typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

docs(eslint-plugin): [comma-dangle] fix incorrect section heading#5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromSevenOutman:patch-1

Jul 18, 2022

Merged

docs(eslint-plugin): [comma-dangle] fix incorrect section heading#5320

bradzacher merged 1 commit intotypescript-eslint:mainfromSevenOutman:patch-1

Jul 18, 2022

Conversation

Copy link

Contributor

SevenOutman commentedJul 7, 2022

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

The "How to Use" section ofcomma-dangle rule was incorrectly titled as "Rule Changes"

docs(comma-dangle): fix incorrect section heading

d1eb688

Copy link

nx-cloudbot commentedJul 7, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd1eb688. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJul 7, 2022

Thanks for the PR,@SevenOutman!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedJul 7, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`d1eb688`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62c65ba4f7b25d0008e20772
😎 Deploy Preview	https://deploy-preview-5320--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedJul 7, 2022•
edited
Loading

Codecov Report

Merging#5320 (d1eb688) intomain (943523d) willincrease coverage by2.42%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5320      +/-   ##==========================================+ Coverage   91.34%   93.76%   +2.42%==========================================  Files         132      287     +155       Lines        1491     9871    +8380       Branches      226     2954    +2728     ==========================================+ Hits         1362     9256    +7894- Misses         65      335     +270- Partials       64      280     +216

Flag	Coverage Δ
unittest	`93.76% <ø> (+2.42%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-extra-semi.ts	`54.54% <0.00%> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`100.00% <0.00%> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.09% <0.00%> (ø)`
...c/rules/no-non-null-asserted-nullish-coalescing.ts	`91.66% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	`90.41% <0.00%> (ø)`
...nt-plugin/src/rules/switch-exhaustiveness-check.ts	`97.95% <0.00%> (ø)`
.../eslint-plugin/src/rules/restrict-plus-operands.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/configs/recommended.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/no-namespace.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/no-unnecessary-type-arguments.ts	`98.14% <0.00%> (ø)`
... and145 more