Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(eslint-plugin): [ban-ts-comment] include descriptionFormat#5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

Cover-up from#5026

@nx-cloud
Copy link

nx-cloudbot commentedJul 2, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9c3294e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJul 2, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9c3294e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62bfb906d4fd2b000928ffed
😎 Deploy Previewhttps://deploy-preview-5283--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedJul 2, 2022
edited
Loading

Codecov Report

Merging#5283 (9c3294e) intomain (75a86d9) willincrease coverage by2.09%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5283      +/-   ##==========================================+ Coverage   91.67%   93.76%   +2.09%==========================================  Files         363      287      -76       Lines       12227     9871    -2356       Branches     3549     2954     -595     ==========================================- Hits        11209     9256    -1953+ Misses        668      335     -333+ Partials      350      280      -70
FlagCoverage Δ
unittest93.76% <ø> (+2.09%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts
packages/utils/src/ast-utils/helpers.ts
packages/utils/src/ts-eslint-scope/Reference.ts
...ckages/utils/src/eslint-utils/getParserServices.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/utils/src/ts-eslint/RuleTester.ts
packages/visitor-keys/src/get-keys.ts
...estree/src/create-program/createIsolatedProgram.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/type-utils/src/getSourceFileOfNode.ts
... and66 more

@bradzacherbradzacher added the documentationDocumentation ("docs") that needs adding/updating labelJul 2, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@bradzacherbradzacher changed the titledocs: [ban-ts-comment] include descriptionFormatdocs(eslint-plugin): [ban-ts-comment] include descriptionFormatJul 2, 2022
@bradzacherbradzacher merged commite5964cf intotypescript-eslint:mainJul 2, 2022
@Josh-CenaJosh-Cena deleted the descriptionFormat-doc branchJuly 2, 2022 04:10
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs:ban-ts-comment is missing description of a newdescriptionFormat option
2 participants
@Josh-Cena@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp