Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(utils): remove (ts-)eslint-scope types#5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJun 26, 2022•
edited by bradzacher
Loading

BREAKING CHANGE:
removes types from the utils package API

PR Checklist

Overview

Per the issue, directly deletes the types.

Ischore(utils)!: ... the right PR title format...?

@nx-cloud
Copy link

nx-cloudbot commentedJun 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitbf185b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5f9ded7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62b8cf63742b6100093170b7
😎 Deploy Previewhttps://deploy-preview-5256--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJune 26, 2022 21:34
@codecov
Copy link

codecovbot commentedJun 26, 2022•
edited
Loading

Codecov Report

Merging#5256 (5f9ded7) intov6 (cf2956f) willincrease coverage by0.21%.
The diff coverage isn/a.

❗ Current head5f9ded7 differs from pull request most recent headbf185b2. Consider uploading reports for the commitbf185b2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #5256      +/-   ##==========================================+ Coverage   91.33%   91.54%   +0.21%==========================================  Files         364      335      -29       Lines       12114    10751    -1363       Branches     3530     3166     -364     ==========================================- Hits        11064     9842    -1222+ Misses        751      594     -157- Partials      299      315      +16
FlagCoverage Δ
unittest91.54% <ø> (+0.21%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/scope-manager/src/scope/index.ts5.26% <0.00%> (-94.74%)⬇️
packages/scope-manager/src/definition/index.ts7.69% <0.00%> (-92.31%)⬇️
packages/utils/src/ts-eslint/index.ts11.11% <0.00%> (-88.89%)⬇️
packages/utils/src/eslint-utils/index.ts12.50% <0.00%> (-87.50%)⬇️
packages/utils/src/ast-utils/eslint-utils/index.ts20.00% <0.00%> (-80.00%)⬇️
packages/utils/src/ast-utils/index.ts25.00% <0.00%> (-75.00%)⬇️
packages/scope-manager/src/index.ts45.45% <0.00%> (-27.28%)⬇️
...s/scope-manager/src/scope/ClassStaticBlockScope.ts75.00% <0.00%> (-25.00%)⬇️
packages/utils/src/eslint-utils/deepMerge.ts89.47% <0.00%> (-10.53%)⬇️
packages/eslint-plugin/src/util/astUtils.ts83.33% <0.00%> (-5.56%)⬇️
... and254 more

@bradzacherbradzacher changed the titlechore(utils)!: remove (ts-)eslint-scope typesfeat(utils): remove (ts-)eslint-scope typesJul 2, 2022
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelJul 2, 2022
@bradzacherbradzacher added this to the6.0.0 milestoneJul 2, 2022
@bradzacherbradzacher changed the base branch frommain tov6October 26, 2022 08:17
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

Don't forget to remove the dependency from the package!

"eslint-scope":"^5.1.1",

JoshuaKGoldberg reacted with laugh emoji
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg merged commitfff0e29 intotypescript-eslint:v6Oct 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the remove-ts-eslint-scope-types branchOctober 26, 2022 14:43
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Removeeslint-scope types fromutils
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp