Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): make docusaurus show twitter card image#5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

connorlurring
Copy link
Contributor

PR Checklist

Overview

Twitter Card docs reference

  • Added Twitter card image (logo-twitter-card.png) with a 2:1 aspect ratio as per the Twitter Card docs.
  • Configured the docusaurusmeta-image property to show this card image.
  • Added alt tag for the image to give support for screen readers.

@nx-cloud
Copy link

nx-cloudbot commentedJun 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9094615. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@connorlurring!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9094615
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62b869da4b71b800083cd785
😎 Deploy Previewhttps://deploy-preview-5253--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@connorlurringconnorlurring changed the titledocs(website): make docusaurus show twitter card imagechore(website): make docusaurus show twitter card imageJun 26, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks for this@connorlurring! 🚀

Althoughview-source:https://deploy-preview-5253--typescript-eslint.netlify.app/ points to the now-404inghttps://typescript-eslint.io/img/logo-twitter-card.png for the image,https://deploy-preview-5253--typescript-eslint.netlify.app/img/logo-twitter-card.png does indeed work. So this should be fine when it hits main.

@connorlurring
Copy link
ContributorAuthor

That's correct Josh, docusaurus uses the base URL set in the config to create the path to the meta image URLs.

When writing it I replaced the base URL with the one to my ngrok tunnel and all worked as expected on the Twitter card tester.

JoshuaKGoldberg reacted with rocket emoji

@JoshuaKGoldbergJoshuaKGoldberg merged commit2600f7f intotypescript-eslint:mainJun 26, 2022
@connorlurringconnorlurring deleted the docs/twitter-card-image branchJune 26, 2022 16:23
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: missing Twitter card image
2 participants
@connorlurring@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp