Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): rework configs: recommended, strict, stylistic; -type-checked#5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJun 25, 2022•
edited
Loading

BREAKING CHANGE:
changes the recommended configs

PR Checklist

Overview

Has each config afterrecommended also include all rules from prior configs. Simplifies what users will have to configure by letting them only specify the strictest desired config.

This is being used to generate the table in#6014.

@JoshuaKGoldbergJoshuaKGoldberg added the breaking changeThis change will require a new major version to be released labelJun 25, 2022
@nx-cloud
Copy link

nx-cloudbot commentedJun 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit48e2f11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1f0c9af
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6358350553902b0009de7910
😎 Deploy Previewhttps://deploy-preview-5251--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat\!: include lesser configs in recommended/strictfeat!: include lesser configs in recommended/strictJun 25, 2022
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJune 26, 2022 21:04
@armano2armano2 added this to the6.0.0 milestoneJun 27, 2022
@bradzacherbradzacher changed the titlefeat!: include lesser configs in recommended/strictfeat(eslint-plugin): include lesser configs in recommended/strictJul 2, 2022
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6October 25, 2022 21:17
Andaristand others added10 commitsOctober 25, 2022 19:59
…pescript-eslint#5036)* refactor(utils)!: removed `TRuleListener` generic from the `createRule`* refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction`* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…ipt-eslint#3076)* feat: update TSImportType node* fix: update visitor keys* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
* feat(scope-manager): ignore ECMA version* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* Remove much more* Fix WebLinter lint* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>* chore: add auto-canary release for v6 (typescript-eslint#5883)Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (typescript-eslint#4863)* chore: remove invalid properties from ast nodes* chore: remove invalid code in scope-manager and typescript-estree* chore: re-write snapshots that were using invalid properties* feat: remove modifiers union from ast typesCo-authored-by: Juan García <juank1809@gmail.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* chore(utils)\!: remove (ts-)eslint-scope types* Remove eslint-scope dep* More file deletions
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 18, 2022 04:15
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

futureisnow_oldman

JoshuaKGoldberg reacted with rocket emoji
Comment on lines 19 to 20
'recommended-requiring-type-checking': recommendedRequiringTypeChecking,
'recommended-type-checked': recommendedTypeChecked,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i was going to say you could save that one file and do this instead:

Suggested change
'recommended-requiring-type-checking':recommendedRequiringTypeChecking,
'recommended-type-checked':recommendedTypeChecked,
'recommended-requiring-type-checking':recommendedTypeChecked,
'recommended-type-checked':recommendedTypeChecked,

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh ha yeah true. And on top of this & v6 overall already being breaking changes, with#6458 we don't have to worry about people reaching intodist/. Great.

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelFeb 13, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit5346b5b intotypescript-eslint:v6Feb 15, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 23, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the config-inclusions branchDecember 28, 2023 15:15
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Configs: Have recommended/strict configs include lesser configs
5 participants
@JoshuaKGoldberg@bradzacher@armano2@Andarist@juank1809
[8]ページ先頭
©2009-2025 Movatter.jp