Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): streamlined Getting Started docs#5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJun 25, 2022•
edited
Loading

PR Checklist

Overview

Applies an editing & streamlining pass to the Getting Started docs.

  • Merges theLinting your TypeScript Codebase file intoGetting Started
    • Exceedingly few users care about developing an ESLint plugin in TypeScript; the extra jump was inconvenient for the majority
  • MovesMonorepo Configuration intoLinting with Type Information since most users don't need it and it's only relevant for typed happenings
  • MovesWhat About TSLint? intoTroubleshooting & FAQs since most users don't need it
  • Removes much of theGetting Started (Linting your TypeScript Codebase) information duplicated from core ESLint docs not necessary for the common path of linting.ts(x) files
  • Explicitly calls it "Quickstart" with numbered steps to help encourage users to directly follow the steps
  • EnablesonBrokenMarkdownLinks and fixes remaining issues

Uses aNetlify_redirects file to preserve the old URLs in case external folks have already linked to them.

@nx-cloud
Copy link

nx-cloudbot commentedJun 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8547ff6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8547ff6
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62dadef5c8f29f0008f10efa
😎 Deploy Previewhttps://deploy-preview-5248--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedJun 25, 2022•
edited
Loading

Codecov Report

Merging#5248 (bbd8692) intomain (48f996e) willincrease coverage by2.42%.
The diff coverage isn/a.

❗ Current headbbd8692 differs from pull request most recent head8547ff6. Consider uploading reports for the commit8547ff6 to get more accurate results

@@            Coverage Diff             @@##             main    #5248      +/-   ##==========================================+ Coverage   91.35%   93.77%   +2.42%==========================================  Files         132      287     +155       Lines        1492     9884    +8392       Branches      226     2961    +2735     ==========================================+ Hits         1363     9269    +7906- Misses         65      335     +270- Partials       64      280     +216
FlagCoverage Δ
unittest93.77% <ø> (+2.42%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...s/eslint-plugin/src/rules/prefer-optional-chain.ts94.21% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts95.12% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts100.00% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-dupe-class-members.ts87.50% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/format.ts83.33% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts98.30% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/base.ts100.00% <0.00%> (ø)
... and145 more

bradzacher
bradzacher previously approved these changesJul 18, 2022
@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)July 22, 2022 17:31
@JoshuaKGoldbergJoshuaKGoldberg merged commit7ea14ae intotypescript-eslint:mainJul 22, 2022
@JoshuaKGoldbergJoshuaKGoldberg mentioned this pull requestJul 23, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 22, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the streamlined-getting-started-docs branchDecember 24, 2022 09:09
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
package: websiteIssues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Proofread Getting Started guide for clarity
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp