Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: removed pre-push hook#5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Per the issue, commits still run Prettier on staged->committed files. We just no longer also run Prettier onall files when pushing.

@nx-cloud
Copy link

nx-cloudbot commentedJun 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5d22ab6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 23, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5d22ab6
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62b48b4d38ec920008b70a07
😎 Deploy Previewhttps://deploy-preview-5235--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJune 23, 2022 16:05
@codecov
Copy link

codecovbot commentedJun 23, 2022•
edited
Loading

Codecov Report

Merging#5235 (5d22ab6) intomain (0957f93) willincrease coverage by0.37%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5235      +/-   ##==========================================+ Coverage   91.33%   91.70%   +0.37%==========================================  Files         132      363     +231       Lines        1488    12205   +10717       Branches      224     3541    +3317     ==========================================+ Hits         1359    11193    +9834- Misses         65      662     +597- Partials       64      350     +286
FlagCoverage Δ
unittest91.70% <ø> (+0.37%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/type-utils/src/getTokenAtPosition.ts0.00% <0.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts78.06% <0.00%> (ø)
packages/eslint-plugin/src/configs/all.ts100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/space-before-blocks.ts100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-parameter-properties.ts94.11% <0.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts92.06% <0.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts75.00% <0.00%> (ø)
.../eslint-plugin/src/rules/no-useless-constructor.ts95.23% <0.00%> (ø)
...nt-plugin/src/rules/lines-between-class-members.ts92.85% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts100.00% <0.00%> (ø)
... and221 more

@bradzacherbradzacher merged commit2de7223 intotypescript-eslint:mainJun 23, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the remove-pre-push-hook branchJune 23, 2022 23:31
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Git hooks should run Prettier only on changed files in commits
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp