typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation#5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromPythonCoderAS:patch-1

Jun 12, 2022

Merged

chore(eslint-plugin): [prefer-optional-chain] fix incorrect syntax in documentation#5172

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromPythonCoderAS:patch-1

Jun 12, 2022

Conversation

Copy link

Contributor

PythonCoderAS commentedJun 12, 2022

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Fixes invalid syntax.

>(((foo||{}).a||{}).b{}).c;(((foo||{}).a||{}).b{}).c;^Uncaught SyntaxError:Unexpectedtoken'{'

Now has become:

>(((foo||{}).a||{}).b||{}).c;undefined

Fix incorrect syntax

856208f

Copy link

nx-cloudbot commentedJun 12, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit856208f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJun 12, 2022

Thanks for the PR,@PythonCoderAS!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedJun 12, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`856208f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62a5cf77dbea3e0009f7e777
😎 Deploy Preview	https://deploy-preview-5172--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedJun 12, 2022•
edited
Loading

Codecov Report

Merging#5172 (856208f) intomain (78af93b) willincrease coverage by2.49%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5172      +/-   ##==========================================+ Coverage   91.33%   93.82%   +2.49%==========================================  Files         132      287     +155       Lines        1488     9862    +8374       Branches      224     2950    +2726     ==========================================+ Hits         1359     9253    +7894- Misses         65      329     +264- Partials       64      280     +216

Flag	Coverage Δ
unittest	`93.82% <ø> (+2.49%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...lugin/src/rules/padding-line-between-statements.ts	`93.83% <0.00%> (ø)`
...src/rules/naming-convention-utils/parse-options.ts	`100.00% <0.00%> (ø)`
...ages/eslint-plugin/src/rules/default-param-last.ts	`100.00% <0.00%> (ø)`
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts	`100.00% <0.00%> (ø)`
...eslint-plugin/src/rules/no-unsafe-member-access.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/array-type.ts	`97.18% <0.00%> (ø)`
packages/eslint-plugin/src/rules/await-thenable.ts	`100.00% <0.00%> (ø)`
...slint-plugin/src/rules/no-unnecessary-qualifier.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/comma-spacing.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/brace-style.ts	`95.34% <0.00%> (ø)`
... and145 more