Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(website): [playground] add links to documentation and improve fixers#5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJun 10, 2022
edited
Loading

PR Checklist

Overview

Playground

  • default fixer is no longer displaying redundant line and its positioned on same line as error,
  • newdetails has been added that points to rule documentation provided by rule
    image
  • rule name is correctly highlighted in tooltip and points to rule documentation
    image

JoshuaKGoldberg reacted with heart emoji
@armano2armano2 added the package: websiteIssues related to the @typescript-eslint website labelJun 10, 2022
@nx-cloud
Copy link

nx-cloudbot commentedJun 10, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb820abe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 10, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb820abe
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62a500a8cd3d7300080a5626
😎 Deploy Previewhttps://deploy-preview-5169--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedJun 10, 2022
edited
Loading

Codecov Report

Merging#5169 (b820abe) intomain (dc1f930) willdecrease coverage by0.22%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5169      +/-   ##==========================================- Coverage   91.55%   91.33%   -0.23%==========================================  Files         344      132     -212       Lines       10801     1488    -9313       Branches     3164      224    -2940     ==========================================- Hits         9889     1359    -8530+ Misses        589       65     -524+ Partials      323       64     -259
FlagCoverage Δ
unittest91.33% <ø> (-0.23%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts
packages/type-utils/src/getDeclaration.ts
...ages/eslint-plugin/src/rules/default-param-last.ts
...t-plugin/src/rules/class-literal-property-style.ts
...kages/eslint-plugin/src/rules/naming-convention.ts
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
...slint-plugin/src/rules/no-unnecessary-qualifier.ts
...ackages/eslint-plugin/src/rules/no-for-in-array.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
... and202 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJun 11, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This isfantastic 👏 Thanks!!

@armano2armano2 merged commit78af93b intomainJun 12, 2022
@armano2armano2 deleted the fix/improve-fix-presentation-and-add-missing-links branchJune 12, 2022 07:41
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Josh-CenaJosh-CenaJosh-Cena left review comments

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
package: websiteIssues related to the @typescript-eslint websitewebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [playground] improve presentation of default fixer in right panel Docs: [playground] add link to rule documentation in list of fixers
3 participants
@armano2@JoshuaKGoldberg@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp