editor and linting is using now exact copy of typescript definitions.
there is no additional calls to cdn to retrieve type definitions, unless sandbox is not exposing types (old ts versions)
lib, options can be provided in tsconfig and its going to be properly used
parsing and validation of tsconfig is done by typescript utils
ctrl+click on types defined in libs is now working correctly
lib: es6

lib: esnext

Test cases

chore(website): [playground] correct issues with changing default lib…

ac39c5f

…s in playground

armano2 added bug

Something isn't working

package: websiteIssues related to the @typescript-eslint website labels

Jun 8, 2022

Copy link

nx-cloudbot commentedJun 8, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit036f13c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJun 8, 2022

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedJun 8, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`036f13c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62a51e5e216f6d0009a77a23
😎 Deploy Preview	https://deploy-preview-5162--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 changed the title~~chore(website): [playground] correct issues with changing default lib~~chore(website): [playground] correct issues with libs

Jun 8, 2022

armano2 added3 commits

June 8, 2022 22:55

chore(website): [playground] default lib to es6 + dom

25d8f18

chore(website): [playground] further refine lib handling, and remove …

5e77452

…cdn call to retrieve them

chore(website): [playground] remove unnecessary ?.

86e97b9

armano2 commented

Jun 8, 2022

View reviewed changes

packages/website/src/components/editor/config.ts OutdatedShow resolvedHide resolved

armano2 commented

Jun 8, 2022

View reviewed changes

packages/website/src/components/editor/useSandboxServices.tsShow resolvedHide resolved

armano2 added2 commits

June 9, 2022 02:25

chore(website): [playground] improve resolving default libs

97266b0

chore(website): [playground] revert incorrect change

3cf6e47

armano2 mentioned this pull request

Jun 9, 2022

chore(website): [playground] support enum values and remove compilerOptions filter#5125

Merged

3 tasks

armano2 requested a review fromJoshuaKGoldberg

June 9, 2022 01:31

bradzacher reviewed

Jun 9, 2022

View reviewed changes

packages/website/src/components/editor/config.ts OutdatedShow resolvedHide resolved

chore(website): [playground] move module augmentation to typings

6ac8fbb

armano2 commented

Jun 9, 2022

View reviewed changes

packages/website/src/components/editor/useSandboxServices.tsShow resolvedHide resolved

fix: improve default lib selection

4997135

Copy link

CollaboratorAuthor

armano2 commentedJun 10, 2022•
edited
Loading

@bradzacher suggested change applied

armano2 commented

Jun 10, 2022

View reviewed changes

packages/website/src/components/editor/config.ts OutdatedShow resolvedHide resolved

armano2 added3 commits

June 10, 2022 03:57

Merge remote-tracking branch 'origin/main' into fix/default-lib-impor…

5ebc151

…t-5142

Merge remote-tracking branch 'origin/main' into fix/default-lib-impor…

34aa7bb

…t-5142

fix: use ts build-in config parsing

ba22b89

Copy link

codecovbot commentedJun 10, 2022•
edited
Loading

Codecov Report

Merging#5162 (036f13c) intomain (dc1f930) willdecrease coverage by0.22%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5162      +/-   ##==========================================- Coverage   91.55%   91.33%   -0.23%==========================================  Files         344      132     -212       Lines       10801     1488    -9313       Branches     3164      224    -2940     ==========================================- Hits         9889     1359    -8530+ Misses        589       65     -524+ Partials      323       64     -259

Flag	Coverage Δ
unittest	`91.33% <ø> (-0.23%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts
...plugin/src/rules/no-unnecessary-type-constraint.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
...lugin/src/rules/prefer-readonly-parameter-types.ts
...nt-plugin/src/rules/indent-new-do-not-use/index.ts
...nt-plugin/src/rules/lines-between-class-members.ts
...internal/src/rules/no-typescript-default-import.ts
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts
...slint-plugin/src/rules/no-unnecessary-qualifier.ts
... and202 more