Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: remove unexpected 'as const' in incorrect example#5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intotypescript-eslint:mainfrommutoe:patch-2
Jun 10, 2022

Conversation

mutoe
Copy link
Contributor

@mutoemutoe commentedJun 8, 2022
edited by armano2
Loading

PR Checklist

Overview

https://deploy-preview-5161--typescript-eslint.netlify.app/rules/explicit-module-boundary-types#allowdirectconstassertioninarrowfunctions

@nx-cloud
Copy link

nx-cloudbot commentedJun 8, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit12419e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mutoe!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 8, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit12419e3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62a297fb8a2d620009e06560
😎 Deploy Previewhttps://deploy-preview-5161--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 added the documentationDocumentation ("docs") that needs adding/updating labelJun 9, 2022
armano2
armano2 previously approved these changesJun 9, 2022
@codecov
Copy link

codecovbot commentedJun 10, 2022

Codecov Report

Merging#5161 (1f02cfe) intomain (921cdf1) willdecrease coverage by0.00%.
The diff coverage isn/a.

❗ Current head1f02cfe differs from pull request most recent head12419e3. Consider uploading reports for the commit12419e3 to get more accurate results

@@            Coverage Diff             @@##             main    #5161      +/-   ##==========================================- Coverage   93.82%   93.82%   -0.01%==========================================  Files         287      286       -1       Lines        9861     9828      -33       Branches     2950     2939      -11     ==========================================- Hits         9252     9221      -31+ Misses        329      328       -1+ Partials      280      279       -1
FlagCoverage Δ
unittest93.82% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin/src/rules/consistent-generic-constructors.ts

@bradzacherbradzacherenabled auto-merge (squash)June 10, 2022 01:02
@bradzacherbradzacher merged commit4a34f1b intotypescript-eslint:mainJun 10, 2022
@mutoemutoe deleted the patch-2 branchJune 11, 2022 14:27
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@armano2armano2armano2 left review comments

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mutoe@armano2@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp