typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore(website): [playground] correct scope analysis class names#5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfromfix/scope-anaylisys-class-names

Jun 4, 2022

Merged

chore(website): [playground] correct scope analysis class names#5140

bradzacher merged 1 commit intomainfromfix/scope-anaylisys-class-names

Jun 4, 2022

Conversation

Copy link

Collaborator

armano2 commentedJun 4, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Do not mangle class names in playground

this is fixing regression from adding source maps to ease debugging

fix(website): [playground] correct scope analysis class names

0ed6275

Copy link

nx-cloudbot commentedJun 4, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0ed6275. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedJun 4, 2022

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedJun 4, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0ed6275`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/629b86355f41ce00087fcc63
😎 Deploy Preview	https://deploy-preview-5140--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 changed the title~~fix(website): [playground] correct scope analysis class names~~chore(website): [playground] correct scope analysis class names

Jun 4, 2022

Copy link

codecovbot commentedJun 4, 2022•
edited
Loading

Codecov Report

Merging#5140 (0ed6275) intomain (ce3083e) willincrease coverage by2.50%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5140      +/-   ##==========================================+ Coverage   91.32%   93.83%   +2.50%==========================================  Files         132      286     +154       Lines        1487     9839    +8352       Branches      224     2939    +2715     ==========================================+ Hits         1358     9232    +7874- Misses         65      328     +263- Partials       64      279     +215

Flag	Coverage Δ
unittest	`93.83% <ø> (+2.50%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts	`96.42% <0.00%> (ø)`
...n/src/rules/no-non-null-asserted-optional-chain.ts	`46.66% <0.00%> (ø)`
...eslint-plugin/src/rules/no-useless-empty-export.ts	`100.00% <0.00%> (ø)`
...lugin/src/rules/consistent-indexed-object-style.ts	`92.06% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/prefer-readonly.ts	`99.08% <0.00%> (ø)`
...slint-plugin/src/rules/prefer-enum-initializers.ts	`100.00% <0.00%> (ø)`
...slint-plugin/src/rules/prefer-namespace-keyword.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/naming-convention-utils/enums.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/restrict-template-expressions.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin/src/rules/no-type-alias.ts	`100.00% <0.00%> (ø)`
... and144 more