Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [space-infix-ops] regression fix for type aliases#5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJun 2, 2022•
edited
Loading

PR Checklist

Overview

Additional regression fix for#5041/^[=|?|:]$/.test(token.value)

@armano2armano2 added bugSomething isn't working package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin labelsJun 2, 2022
@nx-cloud
Copy link

nx-cloudbot commentedJun 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit66e72eb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedJun 2, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit66e72eb
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6298eca42c18ac0009b42839
😎 Deploy Previewhttps://deploy-preview-5138--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedJun 2, 2022•
edited
Loading

Codecov Report

Merging#5138 (66e72eb) intomain (ce3083e) willincrease coverage by2.50%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #5138      +/-   ##==========================================+ Coverage   91.32%   93.83%   +2.50%==========================================  Files         132      286     +154       Lines        1487     9839    +8352       Branches      224     2940    +2716     ==========================================+ Hits         1358     9232    +7874- Misses         65      328     +263- Partials       64      279     +215
FlagCoverage Δ
unittest93.83% <100.00%> (+2.50%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/space-infix-ops.ts100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/comma-dangle.ts93.33% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts94.64% <0.00%> (ø)
...eslint-plugin/src/rules/prefer-return-this-type.ts91.80% <0.00%> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts97.29% <0.00%> (ø)
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts96.38% <0.00%> (ø)
...t-plugin/src/rules/no-confusing-void-expression.ts98.85% <0.00%> (ø)
...es/eslint-plugin/src/configs/eslint-recommended.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts96.29% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-loss-of-precision.ts83.33% <0.00%> (ø)
... and145 more

@bradzacherbradzacher merged commit4e13deb intomainJun 4, 2022
@bradzacherbradzacher deleted the fix/space-infix-ops-type-aslias-declaration branchJune 4, 2022 16:54
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestJun 17, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.27.0` -> `5.27.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.0/5.27.1) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.27.0` -> `5.27.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.0/5.27.1) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.27.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5271-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5270v5271-2022-06-06)[Compare Source](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1)##### Bug Fixes-   **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#&#8203;5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174))-   **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#&#8203;5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8))-   **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#&#8203;5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.27.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5271-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5270v5271-2022-06-06)[Compare Source](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1399Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestJun 17, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.1/5.28.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.1/5.28.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13)[Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0)##### Bug Fixes-   \[TS4.7] allow visiting of typeParameters in TSTypeQuery ([#&#8203;5166](typescript-eslint/typescript-eslint#5166)) ([dc1f930](typescript-eslint/typescript-eslint@dc1f930))-   **eslint-plugin:** \[space-infix-ops] support for optional property without type ([#&#8203;5155](typescript-eslint/typescript-eslint#5155)) ([1f25daf](typescript-eslint/typescript-eslint@1f25daf))##### Features-   **eslint-plugin:** \[consistent-generic-constructors] add rule ([#&#8203;4924](typescript-eslint/typescript-eslint#4924)) ([921cdf1](typescript-eslint/typescript-eslint@921cdf1))#### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06)##### Bug Fixes-   **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#&#8203;5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174))-   **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#&#8203;5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8))-   **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#&#8203;5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13)[Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1409Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [space-infix-ops] rule reports incorrect errors for type alias declaration
2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp