Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): [playground] create new model with jsx support if needed#5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomainfromfix/website-improve-support-for-jsx
Jun 1, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMay 31, 2022
edited
Loading

PR Checklist

Overview

This change fixes issues witch switching from and to jsx


with code:

function x() {  return <div></div>}

before this change if you try to switch to jsx, playground is going to report bunch of issues

Playground #5128Playground main

@nx-cloud
Copy link

nx-cloudbot commentedMay 31, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitebcd3ad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 31, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitebcd3ad
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/629685d71dab960008d7fb3e
😎 Deploy Previewhttps://deploy-preview-5128--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedMay 31, 2022
edited
Loading

Codecov Report

Merging#5128 (ebcd3ad) intomain (c9c0569) willdecrease coverage by0.38%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5128      +/-   ##==========================================- Coverage   91.70%   91.32%   -0.39%==========================================  Files         362      132     -230       Lines       12181     1487   -10694       Branches     3530      224    -3306     ==========================================- Hits        11171     1358    -9813+ Misses        661       65     -596+ Partials      349       64     -285
FlagCoverage Δ
unittest91.32% <ø> (-0.39%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
.../utils/src/ast-utils/eslint-utils/scopeAnalysis.ts
packages/utils/src/ts-eslint/Linter.ts
packages/eslint-plugin/src/util/escapeRegExp.ts
packages/utils/src/eslint-utils/nullThrows.ts
packages/eslint-plugin/src/rules/semi.ts
...kages/eslint-plugin/src/rules/init-declarations.ts
packages/type-utils/src/getContextualType.ts
...n/src/rules/no-non-null-asserted-optional-chain.ts
...-estree/src/create-program/createProjectProgram.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
... and220 more

@armano2armano2 changed the titlechore(website): create new model with jsx support if neededchore(website): [playground] create new model with jsx support if neededMay 31, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

olddudenoice

@bradzacherbradzacher merged commita7fddd0 intomainJun 1, 2022
@bradzacherbradzacher deleted the fix/website-improve-support-for-jsx branchJune 1, 2022 00:42
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp