typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore(website): [playground] support enum values and remove compilerOptions filter#5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 4 commits intomainfromfix/imrpove-visual-editor-to-not-remove-options

Jun 10, 2022

Merged

chore(website): [playground] support enum values and remove compilerOptions filter#5125

bradzacher merged 4 commits intomainfromfix/imrpove-visual-editor-to-not-remove-options

Jun 10, 2022

Conversation

Copy link

Collaborator

armano2 commentedMay 31, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue: related toBug: [no-misused-promises] Possible false positive in 5.27.0 #5121
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

further refine and improve visual config editor, this should correct potential issues with providing configs like in#5121

compilerOptions will no longer be filtered out from not supported values in visualEditor and enum values will be displayed correctly as dropdown fields

additionally fields,moduleResolution, lib, plugins, typeRoots, paths, moduleDetection, baseUrl will be ignored

related to changes done in#5112

chore(website): improve config editor to support enum values and not …

d50799d

…filter compilerOptions

armano2 added the package: websiteIssues related to the @typescript-eslint website label

May 31, 2022

Copy link

nx-cloudbot commentedMay 31, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8ef15c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMay 31, 2022

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedMay 31, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`8ef15c9`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62a2a2e741ea790009e6d44e
😎 Deploy Preview	https://deploy-preview-5125--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 added the enhancementNew feature or request label

May 31, 2022

fix: support for empty values in enum selection

b9ec296

armano2 mentioned this pull request

Jun 8, 2022

chore(website): [playground] correct issues with libs#5162

Merged

3 tasks

armano2 commented

Jun 9, 2022

View reviewed changes

packages/website/src/components/editor/config.ts Outdated

		@@ -13,6 +13,13 @@ export function createCompilerOptions(
		module: window.ts.ModuleKind.ESNext as number,
		...tsConfig,
		jsx: jsx ? window.ts.JsxEmit.Preserve : window.ts.JsxEmit.None,
		moduleResolution: undefined,
		lib: undefined,