Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [space-infix-ops] correct PropertyDefinition with typeAnnotation#5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intomainfromfix/space-infix-ops-5109
May 30, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMay 30, 2022•
edited
Loading

PR Checklist

Overview

correct seelcting last node of PropertyDefinition whentypeAnnotation is present

regression fix for#5041/^[=|?|:]$/.test(token.value)

@nx-cloud
Copy link

nx-cloudbot commentedMay 30, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6077dd0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 30, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6077dd0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/629525581487ee0008063e3d
😎 Deploy Previewhttps://deploy-preview-5113--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 added package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin bugSomething isn't working labelsMay 30, 2022
@codecov
Copy link

codecovbot commentedMay 30, 2022•
edited
Loading

Codecov Report

Merging#5113 (6077dd0) intomain (90f3960) willincrease coverage by2.12%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #5113      +/-   ##==========================================+ Coverage   91.70%   93.83%   +2.12%==========================================  Files         362      286      -76       Lines       12181     9838    -2343       Branches     3530     2939     -591     ==========================================- Hits        11171     9231    -1940+ Misses        661      328     -333+ Partials      349      279      -70
FlagCoverage Δ
unittest93.83% <100.00%> (+2.12%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/space-infix-ops.ts100.00% <100.00%> (ø)
packages/utils/src/ast-utils/helpers.ts
packages/utils/src/ts-eslint/ESLint.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/utils/src/ast-utils/eslint-utils/index.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/utils/src/ts-eslint-scope/Scope.ts
...ckages/utils/src/eslint-utils/getParserServices.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/utils/src/eslint-utils/applyDefault.ts
... and67 more

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL, thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commitd320174 intomainMay 30, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the fix/space-infix-ops-5109 branchMay 30, 2022 20:30
@CyanSalt
Copy link

As mentioned here at#5133 (comment), most of the false positives have been eliminated after I used the version that includes the fix, but the code that contains theextends still triggers similar problems.

typeFoo<T>=Textends{bar:string} ?string :number^
typeFoo<T>=Textends(bar:string)=>void ?string :number^

@armano2
Copy link
CollaboratorAuthor

As mentioned here at#5133 (comment), most of the false positives have been eliminated after I used the version that includes the fix, but the code that contains theextends still triggers similar problems.

i filled new issue for this bug#5134

CyanSalt reacted with heart emoji

@pkudryashov
Copy link

in version5.27.1-alpha.13 error

typeFoo<Textends(...args:any[])=>any>=T;^

@bradzacher
Copy link
Member

As per our contributing guidelines - PRs are not the place to discuss issues. Locking.

@typescript-eslinttypescript-eslint locked and limited conversation to collaboratorsJun 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [space-infix-ops] Spurious warning after upgrade to 5.27.0
5 participants
@armano2@CyanSalt@pkudryashov@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp