typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

test: fix Cypress test flakes#5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromJosh-Cena:fix-cypress

May 28, 2022

Merged

test: fix Cypress test flakes#5086

JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromJosh-Cena:fix-cypress

May 28, 2022

Conversation

Copy link

Member

Josh-Cena commentedMay 27, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixWebsite tests flake: ESOCKETTIMEDOUT #4739
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

ci: cache Cypress binary in install

f5402d7

Copy link

nx-cloudbot commentedMay 27, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite1b3029. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMay 27, 2022

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedMay 27, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e1b3029`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6292a6a719f68f00091d6b53
😎 Deploy Preview	https://deploy-preview-5086--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Josh-Cena commented

May 27, 2022

View reviewed changes

.github/actions/prepare-install/action.yml

		@@ -31,7 +31,9 @@ runs:
		- uses: actions/cache@v3
		id: yarn-cache
		with:
		path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
		path: \|
		${{ steps.yarn-cache-dir-path.outputs.dir }}

Copy link

MemberAuthor

Josh-CenaMay 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is essentially a subpath of~/.cache. I don't know if there would be any adverse effects if we simply cache the entire~/.cache, or if I should constrain it to certain subpaths.

Josh-Cena added2 commits

May 27, 2022 13:51

try again...

25302f0

add wait-on

b0ae288

Copy link

MemberAuthor

Josh-Cena commentedMay 27, 2022•
edited
Loading

I have toyarn cypress install, although I did persist the cache. I don't know if that's fully necessary, but it at least works this way, and doesn't take much time anyway (since the binarydoes get cached)