Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): pass user defined compilerOptions to linter#5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomainfromfix/playground-compiler-options-sync
May 26, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMay 25, 2022
edited
Loading

PR Checklist

Overview

  • fixes issue with playground not respecting jsx options

    web-linter parsed code but you could see error in editor
    const x = <Boo>this.foo();
    Note: changing from and to JSX support in editor requires browser refresh, this is limitation of sandbox

  • allow user-definedcompilerOptions to be passed to WebLinter

    regression fix for bug introduced inchore(website): rewrite WebLinter to typescript and fix support for ts 4.7 #5034

Test cases

@armano2armano2 added bugSomething isn't working package: websiteIssues related to the @typescript-eslint website labelsMay 25, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedMay 25, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit38bbef9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedMay 25, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit38bbef9
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/628f9f75a0bcb1000ab52d04
😎 Deploy Previewhttps://deploy-preview-5080--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher
bradzacher previously approved these changesMay 26, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One quick request - could we makestrict: true the default?
Or at leaststrictNullChecks.

Otherwise
lgtm15.jpg

@armano2
Copy link
CollaboratorAuthor

armano2 commentedMay 26, 2022
edited
Loading

One quick request - could we makestrict: true the default? Or at leaststrictNullChecks.

sadly no, we can't really define defaults, user is not going to be able to disable them for now, changing defaults requires changes to be done in config editor, but that will be done when i get to improving config editor

Config editor currently removes all options that are set to false (yes this is bad, but that's how it was done)

added to backlog,Website Playground (view)

bradzacher reacted with thumbs up emoji

@bradzacherbradzacher changed the titlefix(website): pass user defined compilerOptions to linterchore(website): pass user defined compilerOptions to linterMay 26, 2022
@bradzacherbradzacher merged commit594116e intomainMay 26, 2022
@bradzacherbradzacher deleted the fix/playground-compiler-options-sync branchMay 26, 2022 15:50
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
bugSomething isn't workingpackage: websiteIssues related to the @typescript-eslint websitewebsite: playground
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(website): compiler options are not passed to the lint run
2 participants
@armano2@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp