Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: [TS4.7] support type parameters fortypeof#5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

letx:typeofy.z<w>;

Babel's implementationbabel/babel#14457

klarstrup reacted with thumbs up emoji
@nx-cloud
Copy link

nx-cloudbot commentedMay 24, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8c90aaa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedMay 24, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8c90aaa
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/628d27c9c2f1f500081e02b8
😎 Deploy Previewhttps://deploy-preview-5067--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedMay 24, 2022
edited
Loading

Codecov Report

Merging#5067 (8c90aaa) intomain (3c0f2e3) willincrease coverage by0.37%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #5067      +/-   ##==========================================+ Coverage   91.32%   91.69%   +0.37%==========================================  Files         132      361     +229       Lines        1487    12139   +10652       Branches      224     3525    +3301     ==========================================+ Hits         1358    11131    +9773- Misses         65      658     +593- Partials       64      350     +286
FlagCoverage Δ
unittest91.69% <100.00%> (+0.37%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts98.00% <100.00%> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts100.00% <0.00%> (ø)
packages/type-utils/src/isTypeReadonly.ts85.71% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-throw-literal.ts97.67% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts93.33% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts98.30% <0.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts81.09% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts94.11% <0.00%> (ø)
packages/utils/src/ts-eslint/CLIEngine.ts66.66% <0.00%> (ø)
... and220 more

@bradzacherbradzacher added enhancementNew feature or request ASTPRs and Issues about the AST structure labelsMay 24, 2022
bradzacher
bradzacher previously approved these changesMay 24, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

delete that one file and we can merge this!
thanks so much for doing this!

amazing_

sosukesuzuki reacted with heart emoji
@bradzacherbradzacher merged commit836de79 intotypescript-eslint:mainMay 24, 2022
@sosukesuzukisosukesuzuki deleted the support-type-parameters-for-query-type branchMay 25, 2022 07:17
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
ASTPRs and Issues about the AST structureenhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 4.7 Support
2 participants
@sosukesuzuki@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp