Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): rewrite WebLinter to typescript and fix support for ts 4.7#5034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 8 commits intomainfromfeat/refactor-and-convert-sandbox-to-ts
May 24, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMay 22, 2022•
edited
Loading

PR Checklist

Overview

related to:#4765 (review)#4765 (comment)

- reuse Linter instance- reuse virtual CompilerHost and use utilize typescript-vfs- update ecmaVersion to latest- correct minor issue in ESLintParseResult
@nx-cloud
Copy link

nx-cloudbot commentedMay 22, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita46048a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 22, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita46048a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/628d6a7dacdc8400080adbd3
😎 Deploy Previewhttps://deploy-preview-5034--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 added enhancementNew feature or request package: websiteIssues related to the @typescript-eslint website labelsMay 22, 2022
@armano2armano2 changed the titlechore(website): rewrite webLinerchore(website): rewrite webLiner to typescript and fix support for ts 4.7May 22, 2022
@codecov
Copy link

codecovbot commentedMay 23, 2022•
edited
Loading

Codecov Report

Merging#5034 (a46048a) intomain (d214556) willincrease coverage by0.21%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5034      +/-   ##==========================================+ Coverage   91.32%   91.53%   +0.21%==========================================  Files         132      343     +211       Lines        1487    10750    +9263       Branches      224     3147    +2923     ==========================================+ Hits         1358     9840    +8482- Misses         65      588     +523- Partials       64      322     +258
FlagCoverage Δ
unittest91.53% <ø> (+0.21%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/utils/src/ts-eslint/Linter.ts100.00% <ø> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts100.00% <0.00%> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts98.09% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts100.00% <0.00%> (ø)
.../src/rules/sort-type-union-intersection-members.ts90.74% <0.00%> (ø)
packages/utils/src/eslint-utils/applyDefault.ts100.00% <0.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts93.19% <0.00%> (ø)
.../eslint-plugin/src/rules/triple-slash-reference.ts100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts80.64% <0.00%> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts96.29% <0.00%> (ø)
... and202 more

@armano2
Copy link
CollaboratorAuthor

as for imports, for now we should keep them as they are, and as forgetScriptKind, I imported it from typescript-estree, in separate PR we should think about adding terser or uglify to build pipeline forwebsite-eslint packagesandbox/index.js

@armano2
Copy link
CollaboratorAuthor

getScriptKind updated to take advantage of changes from#5027

@armano2armano2 requested a review frombradzacherMay 24, 2022 23:32
@bradzacherbradzacher changed the titlechore(website): rewrite webLiner to typescript and fix support for ts 4.7chore(website): rewrite WebLinter to typescript and fix support for ts 4.7May 24, 2022
@bradzacherbradzacher merged commit519dd7b intomainMay 24, 2022
@bradzacherbradzacher deleted the feat/refactor-and-convert-sandbox-to-ts branchMay 24, 2022 23:49
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or requestpackage: websiteIssues related to the @typescript-eslint website
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp