Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: [4.7] support new extensions#5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 8 commits intomainfrom4.7-new-extensions
May 24, 2022
Merged

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

This was mostly a find and manual update to include the new extensions.
I made a few tweaks to the code to make it more maintainable as well (like using TS'sExtension enum)

@bradzacherbradzacher added the enhancementNew feature or request labelMay 20, 2022
@nx-cloud
Copy link

nx-cloudbot commentedMay 20, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite2620c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 20, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite2620c5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/628d61980ee66f0009b07165
😎 Deploy Previewhttps://deploy-preview-5027--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

return true;
}
}
return false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: you couldreturn DEFINITION_EXTENSIONS.some(extension => fileName.endsWith(extension)). If you wanted.

Josh-Cena reacted with thumbs up emoji
@@ -33,8 +33,8 @@
"postbuild": "downlevel-dts dist _ts3.4/dist",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist && rimraf _ts3.4 && rimraf coverage",
"format": "prettier --write \"./**/*.{ts,js,json,md}\" --ignore-path ../../.prettierignore",
"lint": "eslint . --ext .js,.ts --ignore-path='../../.eslintignore'",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unless I'm missing something, we can useprettier --write \"./**/*\" --ignore-unknown --ignore-path ../../.prettierignore?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we did this to control the files that get formatted... I forget exactly - it's been so long!
So I just kept it as is. I don't know if we really need to bother with this now.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 23, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, only little non-blockers from me!

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
bradzacherand others added5 commitsMay 23, 2022 14:40
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
@codecov
Copy link

codecovbot commentedMay 24, 2022•
edited
Loading

Codecov Report

Merging#5027 (e2620c5) intomain (9f3121b) willincrease coverage by2.12%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #5027      +/-   ##==========================================+ Coverage   91.68%   93.81%   +2.12%==========================================  Files         361      286      -75       Lines       12128     9811    -2317       Branches     3521     2933     -588     ==========================================- Hits        11120     9204    -1916+ Misses        658      328     -330+ Partials      350      279      -71
FlagCoverage Δ
unittest93.81% <100.00%> (+2.12%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...es/eslint-plugin/src/configs/eslint-recommended.ts100.00% <ø> (ø)
packages/eslint-plugin/src/util/misc.ts96.42% <100.00%> (+2.42%)⬆️
...estree/src/create-program/createIsolatedProgram.ts
...-estree/src/create-program/createProjectProgram.ts
...ript-estree/src/create-program/createSourceFile.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/convert-comments.ts
packages/utils/src/ts-eslint-scope/Referencer.ts
...internal/src/rules/no-typescript-default-import.ts
...ges/utils/src/ast-utils/eslint-utils/predicates.ts
... and69 more

@bradzacherbradzacher merged commitefc147b intomainMay 24, 2022
@bradzacherbradzacher deleted the 4.7-new-extensions branchMay 24, 2022 23:11
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestMay 31, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestMay 31, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestMay 31, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestJun 1, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestJun 1, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestJun 1, 2022
turadg added a commit to Agoric/agoric-sdk that referenced this pull requestJun 1, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestJun 5, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.26.0/5.27.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.26.0/5.27.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30)[Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0)##### Bug Fixes-   **eslint-plugin:** \[no-type-alias] handle Template Literal Types ([#&#8203;5092](typescript-eslint/typescript-eslint#5092)) ([8febf11](typescript-eslint/typescript-eslint@8febf11))##### Features-   \[4.7] support new extensions ([#&#8203;5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b))-   **eslint-plugin:** \[ban-ts-comment] add descriptionFormat option ([#&#8203;5026](typescript-eslint/typescript-eslint#5026)) ([1fb31a4](typescript-eslint/typescript-eslint@1fb31a4))-   **eslint-plugin:** \[no-misused-promises] warn when spreading promises ([#&#8203;5053](typescript-eslint/typescript-eslint#5053)) ([61ffa9e](typescript-eslint/typescript-eslint@61ffa9e))-   **eslint-plugin:** \[space-infix-ops] missing error report for conditional types ([#&#8203;5041](typescript-eslint/typescript-eslint#5041)) ([0bfab6c](typescript-eslint/typescript-eslint@0bfab6c))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30)[Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0)##### Bug Fixes-   **types:** remove leftovers from removal of useJSXTextNode ([#&#8203;5091](typescript-eslint/typescript-eslint#5091)) ([f9c3647](typescript-eslint/typescript-eslint@f9c3647))##### Features-   \[4.7] support new extensions ([#&#8203;5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b))</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1385Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@Josh-CenaJosh-CenaJosh-Cena left review comments

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 4.7 Support
3 participants
@bradzacher@JoshuaKGoldberg@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp