Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: removed commitlint#4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Removes thecommitlint package and lines that reference it.

Also removescommitizen andcz-conventional-changelog. I don't see anything still using them?

@nx-cloud
Copy link

nx-cloudbot commentedMay 15, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3038f95. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 15, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3038f95
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6293a4e04840ad00087fd95a
😎 Deploy Previewhttps://deploy-preview-4981--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedMay 15, 2022•
edited
Loading

Codecov Report

Merging#4981 (3038f95) intomain (dc58ff5) willincrease coverage by0.38%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4981      +/-   ##==========================================+ Coverage   91.32%   91.70%   +0.38%==========================================  Files         132      362     +230       Lines        1487    12181   +10694       Branches      224     3530    +3306     ==========================================+ Hits         1358    11171    +9813- Misses         65      661     +596- Partials       64      349     +285
FlagCoverage Δ
unittest91.70% <ø> (+0.38%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ges/typescript-estree/src/create-program/shared.ts88.09% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-array-constructor.ts100.00% <0.00%> (ø)
...c/rules/no-non-null-asserted-nullish-coalescing.ts91.66% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts97.72% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts100.00% <0.00%> (ø)
packages/type-utils/src/getDeclaration.ts0.00% <0.00%> (ø)
packages/utils/src/eslint-utils/deepMerge.ts89.47% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts98.11% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts80.64% <0.00%> (ø)
... and220 more

@bradzacherbradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs labelMay 15, 2022
@bradzacher
Copy link
Member

bradzacher commentedMay 15, 2022•
edited
Loading

we can add some config to enable the signal for the PR title
https://github.com/zeke/semantic-pull-requests#configuration
File:.github/semantic.yml

enabled:truetitleOnly:truescopes:  -ast-utils  -...types:  -feat  -fix  -docs  -chore  -test  -revert

I've double checked and we have the app installed in the repo so itshould just work?

@bradzacher
Copy link
Member

alternately we could setup our own action instead of using the app
https://github.com/amannn/action-semantic-pull-request

armano2 reacted with thumbs up emoji

@armano2

This comment was marked as resolved.

@bradzacher
Copy link
Member

bradzacher commentedMay 30, 2022•
edited
Loading

Spun off the action discussion as a new issue#5110

@bradzacherbradzacher merged commit90f3960 intotypescript-eslint:mainMay 30, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 30, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the remove-commitlint branchDecember 24, 2022 08:00
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo maintenance: remove commitlint
3 participants
@JoshuaKGoldberg@bradzacher@armano2
[8]ページ先頭
©2009-2025 Movatter.jp