Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: bump dependencies#4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 6 commits intomainfromupdate-deps-2022-05-09
May 10, 2022
Merged

chore: bump dependencies#4952

bradzacher merged 6 commits intomainfromupdate-deps-2022-05-09
May 10, 2022

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedMay 10, 2022•
edited
Loading

Bump all of our dependency versions including ones we couldn't auto-bump

I believe the coverage drop is from the jest upgrade

The outdated packagesafter this PR:

% yarn outdatedyarn outdated v1.22.17info Color legend :  "<red>"    : Major Update backward-incompatible updates  "<yellow>" : Minor Update backward-compatible features  "<green>"  : Patch Update backward-compatible bug fixesPackage                            Current       Wanted        Latest        Workspace                                 Package Type    URL                                          @docusaurus/core                   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/module-type-aliases    2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   devDependencies https://github.com/facebook/docusaurus#readme@docusaurus/plugin-content-docs    2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/plugin-content-pages   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/plugin-debug           2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/remark-plugin-npm2yarn 2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/theme-classic          2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/theme-common           2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@docusaurus/theme-search-algolia   2.0.0-beta.18 2.0.0-beta.20 2.0.0-beta.20 website                                   dependencies    https://github.com/facebook/docusaurus#readme@mdx-js/react                      1.6.22        1.6.22        2.1.1         website                                   dependencies    https://mdxjs.com                            cypress                            8.3.0         8.3.0         9.6.1         website                                   devDependencies https://github.com/cypress-io/cypress        downlevel-dts                      0.9.0         0.9.0         0.10.0        @typescript-eslint/typescript-eslint      devDependencies https://github.com/sandersn/downlevel-dts    eslint-scope                       5.1.1         5.1.1         7.1.1         @typescript-eslint/utils                  dependencies    http://github.com/eslint/eslint-scope        globby                             11.1.0        11.1.0        13.1.1        @typescript-eslint/typescript-estree      dependencies    https://github.com/sindresorhus/globby#readmeglobby                             11.1.0        11.1.0        13.1.1        website                                   devDependencies https://github.com/sindresorhus/globby#readmeprettier                           2.5.1         2.5.1         2.6.2         @typescript-eslint/typescript-eslint      devDependencies https://prettier.io                          prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/eslint-plugin-internal dependencies    https://prettier.io                          prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/eslint-plugin          devDependencies https://prettier.io                          prettier                           2.5.1         2.6.2         2.6.2         @typescript-eslint/scope-manager          devDependencies https://prettier.io
  • prettier i'll do in a separate PR as it'll require a format run
  • globby we can't bump because it's switched to ESM
  • eslint-scope can't be updated without a major -Utils: removeeslint-scope types #4953
  • downlevel-dts has a bug in the new version -[bug] type parameter names are stripped erroneously leading to broken code sandersn/downlevel-dts#77
  • The following are all website packages which I'll leave for now - Josh / Armano / etc can upgrade if they feel the need. It's all majors so it'll probs take effort / code knowledge I don't have 😄.
    • @docusaurus/core,@docusaurus/module-type-aliases,@docusaurus/plugin-content-docs,@docusaurus/plugin-content-pages,@docusaurus/plugin-debug,@docusaurus/remark-plugin-npm2yarn,@docusaurus/theme-classic,@docusaurus/theme-common,@docusaurus/theme-search-algolia,@mdx-js/react,cypress

@bradzacherbradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs labelMay 10, 2022
@nx-cloud
Copy link

nx-cloudbot commentedMay 10, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd43f7d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 10, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd43f7d5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/627ae698d7ff810008c5a48d
😎 Deploy Previewhttps://deploy-preview-4952--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedMay 10, 2022•
edited
Loading

Codecov Report

Merging#4952 (d43f7d5) intomain (7275977) willdecrease coverage by2.46%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4952      +/-   ##==========================================- Coverage   94.25%   91.78%   -2.47%==========================================  Files         153      228      +75       Lines        8305    10633    +2328       Branches     2702     3289     +587     ==========================================+ Hits         7828     9760    +1932- Misses        263      591     +328- Partials      214      282      +68
FlagCoverage Δ
unittest91.78% <ø> (-2.47%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...plugin/src/rules/naming-convention-utils/format.ts83.33% <ø> (ø)
packages/utils/src/ast-utils/predicates.ts95.55% <0.00%> (ø)
packages/utils/src/ast-utils/index.ts25.00% <0.00%> (ø)
packages/type-utils/src/predicates.ts36.23% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts100.00% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts91.30% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts84.32% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts89.79% <0.00%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts97.29% <0.00%> (ø)
...gin-internal/src/rules/no-poorly-typed-ts-props.ts88.88% <0.00%> (ø)
... and66 more

@bradzacherbradzacherforce-pushed theupdate-deps-2022-05-09 branch from615c44c to5db85b3CompareMay 10, 2022 04:08
@bradzacherbradzacher marked this pull request as ready for reviewMay 10, 2022 04:26
@@ -155,8 +154,8 @@ jobs:
flags: unittest
name: codecov

linting_and_style:
name: Code style and lint
spellcheck:
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Split this out just because i was annoyed when one failed and it killed the entire lint job.

JoshuaKGoldberg reacted with thumbs up emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1 from me on the splitup!

...and continued irk at GHA for not making it easy to reuse steps copypasta...

@@ -0,0 +1,2 @@
# see comment in the file
packages/ast-spec/tests/util/parsers/typescript-estree-import.ts
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@JamesHenry - the new version of nx started reporting circular deps, so I had to add this hack back in.

"@types/node": "^16.11.4",
"typescript": "4.6.2"
"@types/node": "^17.0.31",
"pretty-format": "^28.1.0",
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one of the jest packages depends on the old pretty-format version which was breaking the types.

jest-util "27.2.0"
jest-config "27.5.1"
jest-resolve "27.5.1"
jest-util "27.5.1"
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergMay 10, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Grr,@nrwl/jest claims to rely on fixed specific versions of Jest 27 but seems to in fact support Jest 28. Maybe there's an issue for us to file?

This root dependency is the only reason I can find for all the jest@27 versions to still be installed.

bradzacher reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can use yarn to pin the version to 28 across the repo!

JoshuaKGoldberg reacted with thumbs up emoji
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 10, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯

dunno if this'll break anything - but worth a shot.lets see what the Ci signal shows!
@bradzacherbradzacher merged commit1fc4e76 intomainMay 10, 2022
@bradzacherbradzacher deleted the update-deps-2022-05-09 branchMay 10, 2022 23:39
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
repo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp