Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: [4.7] support instantiation expressions#4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzukisosukesuzuki commentedMay 9, 2022•
edited by bradzacher
Loading

PR Checklist

Overview

ref: Babel's implementation (babel/babel#14457)

@nx-cloud
Copy link

nx-cloudbot commentedMay 9, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5d94bbf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedMay 9, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5d94bbf
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62854ec79653a5000811dc86
😎 Deploy Previewhttps://deploy-preview-4938--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacher
Copy link
Member

i merged the version bump so this can be rebased on top of main

@sosukesuzukisosukesuzukiforce-pushed theinstantiation-expression branch fromf8d2bfc toae10fddCompareMay 17, 2022 15:20
@sosukesuzukisosukesuzuki marked this pull request as ready for reviewMay 17, 2022 15:20
@bradzacherbradzacher added enhancementNew feature or request ASTPRs and Issues about the AST structure labelsMay 17, 2022
@sosukesuzukisosukesuzukiforce-pushed theinstantiation-expression branch fromae10fdd toa165519CompareMay 18, 2022 05:28
@codecov
Copy link

codecovbot commentedMay 18, 2022•
edited
Loading

Codecov Report

Merging#4938 (5d94bbf) intomain (08ae2c4) willincrease coverage by0.38%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4938      +/-   ##==========================================+ Coverage   91.32%   91.71%   +0.38%==========================================  Files         132      361     +229       Lines        1487    12124   +10637       Branches      224     3518    +3294     ==========================================+ Hits         1358    11119    +9761- Misses         65      657     +592- Partials       64      348     +284
FlagCoverage Δ
unittest91.71% <100.00%> (+0.38%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts98.39% <100.00%> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts100.00% <0.00%> (ø)
packages/utils/src/ts-eslint/CLIEngine.ts66.66% <0.00%> (ø)
...gin/src/rules/naming-convention-utils/validator.ts95.54% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-extraneous-class.ts100.00% <0.00%> (ø)
packages/visitor-keys/src/get-keys.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/semi.ts92.85% <0.00%> (ø)
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-this-alias.ts100.00% <0.00%> (ø)
... and221 more

@bradzacherbradzacher changed the titlefeat(typescript-estree): Instantiation expressionsfeat: [4.7] support instantiation expressionsMay 19, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM!
Thanks so much for helping us prep for TS4.7

@bradzacherbradzacher merged commit79fbc77 intotypescript-eslint:mainMay 19, 2022
@bradzacherbradzacher mentioned this pull requestMay 19, 2022
@bradennapier
Copy link

bradennapier commentedMay 24, 2022•
edited
Loading

Is this released? As its on main I am just unsure if that triggers a release. Because themakeBox example is still returning as if it does not.

functionmakeBox<T>(value:T){return{ value};}constmakeStringBox=makeBox<string>

image

"@typescript-eslint/eslint-plugin":"^5.26.0","@typescript-eslint/parser":"^5.26.0","eslint":"8.16.0","typescript":"rc"

Typescript is 4.7.1-rc

@bradzacher
Copy link
Member

This is all supported in our project!
This looks like a bug in TS itself, which I have filed:
microsoft/TypeScript#49223

@sosukesuzukisosukesuzuki deleted the instantiation-expression branchMay 31, 2022 11:16
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
ASTPRs and Issues about the AST structureenhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sosukesuzuki@bradzacher@bradennapier
[8]ページ先頭
©2009-2025 Movatter.jp