Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: correct execution of test and dev scripts on Windows machines#4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 4 commits intomainfromtest/executing-tests-on-windows-machines
May 10, 2022

Conversation

armano2
Copy link
Collaborator

PR Checklist

Overview

On Windows machines, allow tests to be executed, and correct issues withprebuild script

@nx-cloud
Copy link

nx-cloudbot commentedMay 9, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit41a4536. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint

This comment was marked as resolved.

@netlify
Copy link

netlifybot commentedMay 9, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit41a4536
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/627a0da6d71e5c0008f6b6ad
😎 Deploy Previewhttps://deploy-preview-4926--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 requested a review frombradzacherMay 9, 2022 01:38
@armano2armano2 added testsanything to do with testing repo maintenancethings to do with maintenance of the repo, and not with code/docs labelsMay 9, 2022
@codecov
Copy link

codecovbot commentedMay 9, 2022•
edited
Loading

Codecov Report

Merging#4926 (41a4536) intomain (7275977) willdecrease coverage by2.47%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4926      +/-   ##==========================================- Coverage   94.25%   91.78%   -2.48%==========================================  Files         153      226      +73       Lines        8305    10626    +2321       Branches     2702     3289     +587     ==========================================+ Hits         7828     9753    +1925- Misses        263      591     +328- Partials      214      282      +68
FlagCoverage Δ
unittest91.78% <ø> (-2.48%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...internal/src/rules/no-typescript-default-import.ts100.00% <0.00%> (ø)
packages/utils/src/ast-utils/predicates.ts95.55% <0.00%> (ø)
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts100.00% <0.00%> (ø)
packages/utils/src/ts-eslint/index.ts11.11% <0.00%> (ø)
packages/type-utils/src/requiresQuoting.ts0.00% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts100.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts100.00% <0.00%> (ø)
packages/typescript-estree/src/ts-estree/index.ts50.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/ScopeManager.ts100.00% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts89.79% <0.00%> (ø)
... and63 more

@armano2
Copy link
CollaboratorAuthor

armano2 commentedMay 10, 2022•
edited
Loading

@bradzacher updated, after further investigation, glob/globby (most likely fast-glob) is no longer working correctly when path has mixed slash and backslash on windows machines, I fixed that by use of cwd and absolute param

bradzacher reacted with thumbs up emoji

@armano2armano2 requested a review frombradzacherMay 10, 2022 07:25
@bradzacherbradzacher merged commit77e15a9 intomainMay 10, 2022
@bradzacherbradzacher deleted the test/executing-tests-on-windows-machines branchMay 10, 2022 23:39
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenancethings to do with maintenance of the repo, and not with code/docstestsanything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp