This rule has been moved to suggestion, as it can report false-positives (around{} being the actual constraint)
The algorithm for adding trailing commas is improved: it now only adds a trailing comma where there's actual ambiguity, preventing some weird syntax errors being generated.

fix(eslint-plugin): [no-unnecessary-type-contraint] change to suggest…

ccb0d01

…ion fix, fix multiple trailing comma failures

Copy link

nx-cloudbot commentedMay 4, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0b69748. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedMay 4, 2022

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedMay 4, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0b69748`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6274c455af90a9000820e5ca
😎 Deploy Preview	https://deploy-preview-4901--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Josh-Cena commented

May 4, 2022

View reviewed changes

packages/eslint-plugin/tests/rules/no-unnecessary-type-constraint.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts

		return (
		(node.parent as TSESTree.TSTypeParameterDeclaration).params.length ===
		1 &&
		source.getTokensAfter(node)[0].value !== ',' &&

Copy link

MemberAuthor

Josh-CenaMay 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know a better way to get the presence of trailing comma...

Copy link

Member

JoshuaKGoldbergMay 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(me neither!)

JoshuaKGoldberg changed the title~~fix(eslint-plugin): [no-unnecessary-type-contraint] change to suggestion fix, fix multiple trailing comma failures~~fix(eslint-plugin): [no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures

May 5, 2022

JoshuaKGoldberg requested changes

May 5, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great so far! Posted a suggestion about the whitespace shenanigans, and a request for a bit more testing. But the logic looks good!

packages/eslint-plugin/tests/rules/no-unnecessary-type-constraint.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

May 5, 2022

Josh-Cena added2 commits

May 5, 2022 23:24

test: fix

35f3d1e

docs: update

aa34afa

JoshuaKGoldberg previously approved these changes

May 5, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks! ✨

JoshuaKGoldbergenabled auto-merge (squash)

May 5, 2022 15:42

Josh-Cena mentioned this pull request

May 5, 2022

@typescript-eslint/internal/plugin-test-formatting too strict about snapshot indentation#4911

Closed

Copy link

MemberAuthor

Josh-Cena commentedMay 6, 2022

I'm not sure why the docs test is erroring. I've already removed the fixable icon.

Copy link

Member

bradzacher commentedMay 6, 2022

I'm not sure why the docs test is erroring. I've already removed the fixable icon.

there are two rules lists that need to be updated.
runyarn generate:rules-lists in the plugin package root to update the tables automatically.

docs: fix

0b69748

auto-merge was automatically disabled

May 6, 2022 06:46

Head branch was pushed to by a user without write access

Josh-Cena dismissedJoshuaKGoldberg’sstale review via0b69748

May 6, 2022 06:46

Copy link

codecovbot commentedMay 6, 2022•
edited
Loading

Codecov Report

Merging#4901 (0b69748) intomain (47f4605) willincrease coverage by2.49%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4901      +/-   ##==========================================+ Coverage   91.76%   94.25%   +2.49%==========================================  Files         226      153      -73       Lines       10586     8305    -2281       Branches     3280     2702     -578     ==========================================- Hits         9714     7828    -1886+ Misses        591      263     -328+ Partials      281      214      -67

Flag	Coverage Δ
unittest	`94.25% <100.00%> (+2.49%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts	`96.42% <100.00%> (-0.07%)`	⬇️
...plugin/src/rules/no-unnecessary-type-constraint.ts	`88.00% <100.00%> (+3.00%)`	⬆️
packages/utils/src/ts-eslint/ESLint.ts
packages/utils/src/ts-eslint/RuleTester.ts
packages/utils/src/ts-eslint/SourceCode.ts
packages/utils/src/eslint-utils/applyDefault.ts
packages/utils/src/ts-eslint-scope/ScopeManager.ts
packages/type-utils/src/isTypeReadonly.ts
...ils/src/ast-utils/eslint-utils/ReferenceTracker.ts
packages/type-utils/src/getContextualType.ts
... and65 more

bradzacher approved these changes

May 6, 2022

View reviewed changes

Copy link

Member

bradzacher commentedMay 6, 2022

thanks for this!

bradzacher added bugSomething isn't working and removed awaiting responseIssues waiting for a reply from the OP or another party labels

May 6, 2022

bradzacher merged commit4507ac8 intotypescript-eslint:main

May 6, 2022

Josh-Cena deleted the fix-type-constraint branch

May 6, 2022 07:07

Josh-Cena mentioned this pull request

May 7, 2022

[no-unnecessary-type-constraint] fixing as suggested can lead to a TS error#3509

Closed

3 tasks

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

May 13, 2022

Update typescript-eslint monorepo to v5.23.0 (#1345)

32fd26c

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.22.0/5.23.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.22.0/5.23.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09)[Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0)##### Bug Fixes-   **eslint-plugin:** \[no-restricted-imports] allow type import as long as there's one matching pattern ([#&#8203;4898](typescript-eslint/typescript-eslint#4898)) ([0419d28](typescript-eslint/typescript-eslint@0419d28))-   **eslint-plugin:** \[no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures ([#&#8203;4901](typescript-eslint/typescript-eslint#4901)) ([4507ac8](typescript-eslint/typescript-eslint@4507ac8))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09)[Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1345Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actionsbot locked asresolvedand limited conversation to collaborators

Jun 6, 2022

Labels

bug

Something isn't working

3 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures#4901

fix(eslint-plugin): [no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures#4901

Uh oh!

Conversation

Josh-Cena commentedMay 4, 2022

PR Checklist

Overview

Uh oh!

nx-cloudbot commentedMay 4, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedMay 4, 2022

Uh oh!

netlifybot commentedMay 4, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

Uh oh!

Josh-CenaMay 4, 2022

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergMay 5, 2022

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Josh-Cena commentedMay 6, 2022

Uh oh!

bradzacher commentedMay 6, 2022

Uh oh!

codecovbot commentedMay 6, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bradzacher commentedMay 6, 2022

Uh oh!

Uh oh!

nx-cloudbot commentedMay 4, 2022•
edited
Loading

netlifybot commentedMay 4, 2022•
edited
Loading

codecovbot commentedMay 6, 2022•
edited
Loading