Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [no-restricted-imports] allow type import as long as there's one matching pattern#4898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… as there's one matching pattern
nx-cloudbot commentedMay 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the PR,@Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
netlifybot commentedMay 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
codecovbot commentedMay 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #4898 +/- ##==========================================+ Coverage 91.76% 94.25% +2.49%========================================== Files 226 153 -73 Lines 10586 8300 -2286 Branches 3280 2700 -580 ==========================================- Hits 9714 7823 -1891+ Misses 591 263 -328+ Partials 281 214 -67
Flags with carried forward coverage won't be shown.Click here to find out more. |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for fixing this!
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.22.0/5.23.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.22.0/5.23.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09)[Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0)##### Bug Fixes- **eslint-plugin:** \[no-restricted-imports] allow type import as long as there's one matching pattern ([#​4898](typescript-eslint/typescript-eslint#4898)) ([0419d28](typescript-eslint/typescript-eslint@0419d28))- **eslint-plugin:** \[no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures ([#​4901](typescript-eslint/typescript-eslint#4901)) ([4507ac8](typescript-eslint/typescript-eslint@4507ac8))</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09)[Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1345Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
allowTypeImportsbreak validation #4895Overview
The problem with our current logic is that we requireevery allowed import pattern to match a given path, but in practice, they can well be disjoint! With this change, we will be more permissive and allow type import as long asone matcher matches.
This may lead to some false-negatives? For example, there are two matchers that both match a file, one with
allowTypeImports, another without. Previously, we report an error; now we don't. To be fair, both seem like valid behaviors to me. We don't have existing test-cases covering that anyways, and it doesn't seem like we have this behavior specced in the docs, so I assume either is fine.