Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(ast-spec): correctAwaitExpression.argument type#4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intotypescript-eslint:mainfromddubrava:add-left-side-expression-to-import-expression
May 2, 2022
Merged

fix(ast-spec): correctAwaitExpression.argument type#4880

bradzacher merged 3 commits intotypescript-eslint:mainfromddubrava:add-left-side-expression-to-import-expression
May 2, 2022

Conversation

ddubrava
Copy link
Contributor

PR Checklist

Overview

ImportExpression is added toLeftHandSideExpression.

G-Rath reacted with hooray emoji
@nx-cloud
Copy link

nx-cloudbot commentedApr 29, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd66baab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ddubrava!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedApr 29, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd66baab
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/626c503e28118f00096d11e5
😎 Deploy Previewhttps://deploy-preview-4880--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#4880 (d66baab) intomain (63fbbaa) willdecrease coverage by0.70%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4880      +/-   ##==========================================- Coverage   92.49%   91.78%   -0.71%==========================================  Files         346      228     -118       Lines       11684    10633    -1051       Branches     3335     3290      -45     ==========================================- Hits        10807     9760    -1047+ Misses        608      591      -17- Partials      269      282      +13
FlagCoverage Δ
unittest91.78% <100.00%> (-0.71%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...gin/src/rules/non-nullable-type-assertion-style.ts100.00% <100.00%> (ø)
packages/utils/src/json-schema.ts5.55% <0.00%> (-94.45%)⬇️
packages/utils/src/ts-eslint/index.ts11.11% <0.00%> (-88.89%)⬇️
packages/utils/src/eslint-utils/index.ts12.50% <0.00%> (-87.50%)⬇️
packages/utils/src/ts-eslint-scope/index.ts18.18% <0.00%> (-81.82%)⬇️
packages/utils/src/ts-eslint/ParserOptions.ts20.00% <0.00%> (-80.00%)⬇️
packages/utils/src/ast-utils/eslint-utils/index.ts20.00% <0.00%> (-80.00%)⬇️
packages/utils/src/ast-utils/index.ts25.00% <0.00%> (-75.00%)⬇️
packages/typescript-estree/src/ts-estree/index.ts50.00% <0.00%> (-50.00%)⬇️
packages/eslint-plugin/src/util/astUtils.ts83.33% <0.00%> (-5.56%)⬇️
... and223 more

@bradzacher
Copy link
Member

Sorry, I realised that I wasvery wrong when I wrote that comment. I wasn't thinking right.

Our types forAwaitExpression are very wrong.

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/ast-spec/src/expression/AwaitExpression/spec.ts#L9

This type should just beExpression, not a custom union.

@bradzacherbradzacher added bugSomething isn't working awaiting responseIssues waiting for a reply from the OP or another party labelsApr 29, 2022
@ddubrava
Copy link
ContributorAuthor

If you prefer force pushing here let me know. as according to your contributing.md, there is a request not to force push

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Brilliant - thanks for fixing this!

@bradzacherbradzacher changed the titlefix(ast-spec): add ImportExpression to LeftHandSideExpression typefix(ast-spec): correctAwaitExpression.argument typeMay 2, 2022
@bradzacherbradzacher merged commit3ec5f53 intotypescript-eslint:mainMay 2, 2022
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 2, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AwaitExpression does not includeImportExpression as possible value ofargument property
2 participants
@ddubrava@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp