Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(eslint-plugin): improve docs [parameter-properties]#4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfrommiZyind:docs/parameter-properties
Apr 29, 2022
Merged

docs(eslint-plugin): improve docs [parameter-properties]#4879

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfrommiZyind:docs/parameter-properties
Apr 29, 2022

Conversation

miZyind
Copy link
Contributor

@miZyindmiZyind commentedApr 29, 2022•
edited
Loading

PR Checklist

Overview

I got this error when I first try this new rule by following the example on the document:

Configuration for rule "@typescript-eslint/parameter-properties" is invalid:Value "parameter-properties" should be equal to one of the allowed values.

and here is my config:

"@typescript-eslint/parameter-properties": [  "error",  {    "prefer": "parameter-properties"  }]

I checked thesource code.
And found that the correct values of theprefer option should be:class-property,parameter-property.
However, the document showsclass-properties andparameter-properties.

According to the schema of thesource code, theallows option should be corrected toallow as well.

@nx-cloud
Copy link

nx-cloudbot commentedApr 29, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit78757fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@miZyind!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedApr 29, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit78757fd
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/626b92b6de20cc0008bea680
😎 Deploy Previewhttps://deploy-preview-4879--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#4879 (78757fd) intomain (f3cf87b) willincrease coverage by2.48%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #4879      +/-   ##==========================================+ Coverage   91.77%   94.25%   +2.48%==========================================  Files         227      153      -74       Lines       10611     8305    -2306       Branches     3283     2703     -580     ==========================================- Hits         9738     7828    -1910+ Misses        591      263     -328+ Partials      282      214      -68
FlagCoverage Δ
unittest94.25% <100.00%> (+2.48%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/configs/all.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts100.00% <100.00%> (ø)
...slint-plugin/src/rules/no-duplicate-enum-values.ts100.00% <100.00%> (ø)
packages/utils/src/ts-eslint/Linter.ts
packages/typescript-estree/src/node-utils.ts
packages/typescript-estree/src/ast-converter.ts
packages/type-utils/src/getContextualType.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/utils/src/ts-eslint-scope/index.ts
...internal/src/rules/no-typescript-default-import.ts
... and68 more

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

D'oh, thanks!

miZyind reacted with hooray emoji
@JoshuaKGoldbergJoshuaKGoldberg changed the titledocs(eslint-plugin): improve docs [no-parameter-properties]docs(eslint-plugin): improve docs [parameter-properties]Apr 29, 2022
@JoshuaKGoldbergJoshuaKGoldberg merged commitb53de9b intotypescript-eslint:mainApr 29, 2022
@miZyindmiZyind deleted the docs/parameter-properties branchApril 30, 2022 06:08
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 31, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: correct example of parameter-properties
2 participants
@miZyind@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp