Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclaration#4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:v6fromjuank1809:semantically-bad-properties
Oct 26, 2022

Conversation

juank1809
Copy link
Contributor

@juank1809juank1809 commentedApr 25, 2022•
edited by bradzacher
Loading

BREAKING CHANGE:
Removes properties from AST node types.

PR Checklist

Overview

Remove incorrect and useless properties from the AST nodes as we are not erroring this kind of semantically code; additionally removed one deprecated function in the converter file that used unsuitable modifiers forTSModuleDeclaration, TSEnumDeclaration and TSInterfaceDeclaration and instead used the utility hasModifier function to handle theconst anddeclare properties when we are analyzing these typescript AST nodes.

The only code I trace using these invalid properties outside the typescript-estree package was in the scope-manager handling wrong interface inheritance.
Some snapshots were re-written as expected.

@nx-cloud
Copy link

nx-cloudbot commentedApr 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita69faeb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@juank1809!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedApr 25, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit7ca78b1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62850820c3448b0008178113

@codecov
Copy link

codecovbot commentedApr 25, 2022•
edited
Loading

Codecov Report

Merging#4863 (a69faeb) intov6 (04488c2) willdecrease coverage by0.02%.
The diff coverage is100.00%.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #4863      +/-   ##==========================================- Coverage   91.36%   91.34%   -0.03%==========================================  Files         364      364                Lines       12143    12125      -18       Branches     3543     3540       -3     ==========================================- Hits        11095    11076      -19- Misses        748      749       +1  Partials      300      300
FlagCoverage Δ
unittest91.34% <100.00%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts98.98% <ø> (+0.98%)⬆️
packages/typescript-estree/src/convert.ts97.59% <100.00%> (-0.32%)⬇️

@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelApr 27, 2022
@bradzacherbradzacher added this to the6.0.0 milestoneApr 27, 2022
@bradzacherbradzacher changed the titleSemantically bad propertiesfeat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclarationApr 27, 2022
@bradzacherbradzacher added the ASTPRs and Issues about the AST structure labelApr 27, 2022
@armano2
Copy link
Collaborator

can you removeModifiers from ast types?

juank1809 reacted with thumbs up emoji

@bradzacherbradzacher changed the base branch frommain tov6October 26, 2022 01:42
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks for this@juank1809!

We're starting work on v6 now, so I'll merge this into thev6 branch. Woop!

juank1809 reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitcf2956f intotypescript-eslint:v6Oct 26, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
ASTPRs and Issues about the AST structurebreaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Remove properties that are used by invalid code
4 participants
@juank1809@armano2@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp