Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: remove duplicate period inmethod-signature-style#4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromybiquitous:patch-1
Apr 23, 2022
Merged

Conversation

ybiquitous
Copy link
Contributor

PR Checklist

Overview

I believe this is just a typo.

@nx-cloud
Copy link

nx-cloudbot commentedApr 23, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitccd6997. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ybiquitous!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedApr 23, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitccd6997
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/626362ee3c03e20008edaf3c
😎 Deploy Previewhttps://deploy-preview-4849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@ybiquitousybiquitous marked this pull request as draftApril 23, 2022 02:11
@ybiquitousybiquitous marked this pull request as ready for reviewApril 23, 2022 02:23
@codecov
Copy link

codecovbot commentedApr 23, 2022
edited
Loading

Codecov Report

Merging#4849 (ccd6997) intomain (88ed9ec) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #4849   +/-   ##=======================================  Coverage   94.23%   94.24%           =======================================  Files         152      152             Lines        8281     8282    +1       Branches     2694     2695    +1     =======================================+ Hits         7804     7805    +1  Misses        263      263             Partials      214      214
FlagCoverage Δ
unittest94.24% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts89.15% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts98.25% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts100.00% <100.00%> (ø)

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, thanks!

ybiquitous reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit5ad70db intotypescript-eslint:mainApr 23, 2022
@ybiquitousybiquitous deleted the patch-1 branchApril 23, 2022 04:49
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ybiquitous@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp