Previously,isVoidReturningFunctionType immediately returnedtrue as soon as it found avoid return. This meant a=> void type before a=> Promise<...> in a union would return before checking the latter case.

fix(eslint-plugin): prioritize false returns when checking whether a …

9b0e5ef

…function returns only void

Copy link

nx-cloudbot commentedApr 20, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5c02b2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedApr 20, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedApr 20, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5c02b2c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6262e8878b8cdc000869c505
😎 Deploy Preview	https://deploy-preview-4841--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg mentioned this pull request

Apr 20, 2022

[no-misused-promises] non-thenable thenable union react component attribute does not accept thenable function#4650

Closed

3 tasks

Copy link

codecovbot commentedApr 20, 2022•
edited
Loading

Codecov Report

Merging#4841 (5c02b2c) intomain (88ed9ec) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #4841   +/-   ##=======================================  Coverage   94.23%   94.24%           =======================================  Files         152      152             Lines        8281     8282    +1       Branches     2694     2695    +1     =======================================+ Hits         7804     7805    +1  Misses        263      263             Partials      214      214

Flag	Coverage Δ
unittest	`94.24% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`98.25% <100.00%> (ø)`
packages/eslint-plugin/src/rules/no-namespace.ts	`100.00% <100.00%> (ø)`

JoshuaKGoldberg requested a review frombradzacher

April 20, 2022 12:44

bradzacher added the bugSomething isn't working label

Apr 22, 2022

bradzacher reviewed

Apr 22, 2022

View reviewed changes

packages/eslint-plugin/tests/rules/no-misused-promises.test.ts OutdatedShow resolvedHide resolved

bradzacher changed the title~~fix(eslint-plugin): prioritize false returns when checking whether a function returns only void~~fix(eslint-plugin): [no-misused-promises] prioritize false returns when checking whether a function returns only void

Apr 22, 2022

bradzacher previously approved these changes

Apr 22, 2022

View reviewed changes

Merge branch 'main' into no-misused-promises-lazy-unions

db904ca

JoshuaKGoldberg dismissedbradzacher’sstale review via1e3af13

April 22, 2022 17:17

Update packages/eslint-plugin/tests/rules/no-misused-promises.test.ts

1e3af13

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

JoshuaKGoldbergenabled auto-merge (squash)

April 22, 2022 17:18

Merge branch 'main' into no-misused-promises-lazy-unions

5c02b2c

JoshuaKGoldbergdisabled auto-merge

April 22, 2022 17:40

JoshuaKGoldberg requested a review frombradzacher

April 22, 2022 17:40

Copy link

MemberAuthor

JoshuaKGoldberg commentedApr 22, 2022

Grr, mistimed the auto-updating...

bradzacher approved these changes

Apr 22, 2022

View reviewed changes

JoshuaKGoldberg merged commitccadb60 intotypescript-eslint:main

Apr 22, 2022

JoshuaKGoldberg deleted the no-misused-promises-lazy-unions branch

April 22, 2022 18:15

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

May 1, 2022

Update typescript-eslint monorepo to v5.21.0 (#1319)

c76cc83

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.20.0` -> `5.21.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.20.0/5.21.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.20.0` -> `5.21.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.20.0/5.21.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.21.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5200v5210-2022-04-25)[Compare Source](typescript-eslint/typescript-eslint@v5.20.0...v5.21.0)##### Bug Fixes-   **eslint-plugin:** \[no-misused-promises] prioritize false returns when checking whether a function returns only void ([#&#8203;4841](typescript-eslint/typescript-eslint#4841)) ([ccadb60](typescript-eslint/typescript-eslint@ccadb60))-   **eslint-plugin:** \[no-namespace] fix false positive for exported namespaces when allowDeclarations=true ([#&#8203;4844](typescript-eslint/typescript-eslint#4844)) ([4e7c9be](typescript-eslint/typescript-eslint@4e7c9be))-   **eslint-plugin:** \[space-infix-ops] fix no error when right type is function ([#&#8203;4848](typescript-eslint/typescript-eslint#4848)) ([d74d559](typescript-eslint/typescript-eslint@d74d559))##### Features-   **eslint-plugin:** \[parameter-properties] add rule to replace `no-parameter-properties` ([#&#8203;4622](typescript-eslint/typescript-eslint#4622)) ([88ed9ec](typescript-eslint/typescript-eslint@88ed9ec))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.21.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5200v5210-2022-04-25)[Compare Source](typescript-eslint/typescript-eslint@v5.20.0...v5.21.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1319Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actionsbot locked asresolvedand limited conversation to collaborators

May 23, 2022

Labels

bug

Something isn't working

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-misused-promises] prioritize false returns when checking whether a function returns only void#4841

fix(eslint-plugin): [no-misused-promises] prioritize false returns when checking whether a function returns only void#4841

Uh oh!

Conversation

JoshuaKGoldberg commentedApr 20, 2022

PR Checklist

Overview

Uh oh!

nx-cloudbot commentedApr 20, 2022•
edited
Loading

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedApr 20, 2022

Uh oh!

netlifybot commentedApr 20, 2022•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedApr 20, 2022•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoshuaKGoldberg commentedApr 22, 2022

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-misused-promises] prioritize false returns when checking whether a function returns only void#4841

fix(eslint-plugin): [no-misused-promises] prioritize false returns when checking whether a function returns only void#4841

Uh oh!

Conversation

JoshuaKGoldberg commentedApr 20, 2022

PR Checklist

Overview

Uh oh!

nx-cloudbot commentedApr 20, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedApr 20, 2022

Uh oh!

netlifybot commentedApr 20, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedApr 20, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoshuaKGoldberg commentedApr 22, 2022

Uh oh!

Uh oh!

nx-cloudbot commentedApr 20, 2022•
edited
Loading

netlifybot commentedApr 20, 2022•
edited
Loading

codecovbot commentedApr 20, 2022•
edited
Loading