typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(typescript-estree):`typeof` private identifiers#4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

sosukesuzuki wants to merge10 commits intotypescript-eslint:mainfromsosukesuzuki:typeof-private

Closed

feat(typescript-estree):`typeof` private identifiers#4832

sosukesuzuki wants to merge10 commits intotypescript-eslint:mainfromsosukesuzuki:typeof-private

Conversation

Copy link

Contributor

sosukesuzuki commentedApr 17, 2022•
edited by bradzacher
Loading

PR Checklist

Addresses an existing open issue: refTypeScript 4.7 Support #4800
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Based on#4829

Adds tests fortypeof this.#foo

sosukesuzuki added10 commits

April 13, 2022 00:55

feat: update to TypeScript 4.7-beta

b4c9ac9

chore(ast-spec): removeapi-extractor temporary

97d5c79

feat(types): rungenerate:lib

7b1c198

chore(typescript-estree): addts.TypeQueryNode to `EstreeToTsNodeTy…

547d172

…pes[TSTypeParameterInstantiation]`

fix(utils): fix type errors

cb305c0

fix(eslint-plugin): avoid syntax errors

eb2bcc5

fix(eslint-plugin): avoid type errors

c390c67

test(typescript-estree): update snapshots

04efb6c

feat(ast-spec): addPrivateIdentifier toTSQualifiedName.right

ee04ac6

test(typescript-estree): add tests fortypeof private

af7b0f3

Copy link

nx-cloudbot commentedApr 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitaf7b0f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`Node 12.x - nx run-many --target=build --all --parallel --exclude website`
`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website`
`Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website`

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedApr 17, 2022

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedApr 17, 2022•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

Name	Link
🔨 Latest commit	`af7b0f3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/625bf46dc6818b0008efe7cc

bradzacher reviewed

Apr 17, 2022

View reviewed changes

packages/ast-spec/src/type/TSQualifiedName/spec.ts

		import type { EntityName } from '../../unions/EntityName';

		export interface TSQualifiedName extends BaseNode {
		type: AST_NODE_TYPES.TSQualifiedName;
		left: EntityName;
		right: Identifier;
		right: Identifier \| PrivateIdentifier;

Copy link

Member

bradzacherApr 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

NGL - I do hate this a little bit because the only place thatthis.#foo is valid is in atypeof. It just means that consumers will have to check the type of this even though they'll know it's not possible.

It's probably not worth going to the effort of creating a separate AST node just for private member expressions within a type query.