typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat: [4.7] support optional variance annotation#4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 12 commits intotypescript-eslint:mainfromsosukesuzuki:optional-variance

May 19, 2022

Merged

feat: [4.7] support optional variance annotation#4831

bradzacher merged 12 commits intotypescript-eslint:mainfromsosukesuzuki:optional-variance

May 19, 2022

Conversation

Copy link

Contributor

sosukesuzuki commentedApr 17, 2022•
edited by bradzacher
Loading

PR Checklist

Addresses an existing open issue: refTypeScript 4.7 Support #4800
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Based on#4829

Support optional variance syntax.

Copy link

nx-cloudbot commentedApr 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit68c350b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedApr 17, 2022

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedApr 17, 2022•
edited
Loading

👷 Deploy request fortypescript-eslint pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`68c350b`

bradzacher added the ASTPRs and Issues about the AST structure label

Apr 25, 2022

sosukesuzuki force-pushed theoptional-variance branch fromcff13e4 toc88f8efCompare

May 9, 2022 15:28

Copy link

Member

bradzacher commentedMay 16, 2022

i merged the version bump so this can be rebased on top of main

sosukesuzuki added4 commits

May 18, 2022 00:14

feat(ast-spec): addin andout toTSTypeParameter

5d9f45f

feat(typescript-estree): addin andout toTSTypeParameter

0a74ba8

test(typescript-estree): add tests for optional variance syntax

0eb5560

test(typescript-estree): update snapshots

435f610

sosukesuzuki force-pushed theoptional-variance branch fromc88f8ef to435f610Compare

May 17, 2022 15:15

sosukesuzuki marked this pull request as ready for review

May 17, 2022 15:16

Copy link

codecovbot commentedMay 17, 2022•
edited
Loading

Codecov Report

Merging#4831 (68c350b) intomain (c673e15) willincrease coverage by0.38%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4831      +/-   ##==========================================+ Coverage   91.32%   91.70%   +0.38%==========================================  Files         132      359     +227       Lines        1487    12117   +10630       Branches      224     3518    +3294     ==========================================+ Hits         1358    11112    +9754- Misses         65      657     +592- Partials       64      348     +284

Flag	Coverage Δ
unittest	`91.70% <ø> (+0.38%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	`98.39% <ø> (ø)`
packages/eslint-plugin/src/rules/no-shadow.ts	`78.48% <0.00%> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.09% <0.00%> (ø)`
packages/eslint-plugin/src/rules/dot-notation.ts	`96.29% <0.00%> (ø)`
packages/type-utils/src/isTypeReadonly.ts	`85.71% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/no-explicit-any.ts	`92.85% <0.00%> (ø)`
...ges/eslint-plugin/src/rules/no-extraneous-class.ts	`100.00% <0.00%> (ø)`
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts	`100.00% <0.00%> (ø)`
packages/utils/src/ast-utils/eslint-utils/index.ts	`20.00% <0.00%> (ø)`
...-plugin/src/rules/restrict-template-expressions.ts	`100.00% <0.00%> (ø)`
... and218 more

armano2 reviewed

May 17, 2022

View reviewed changes

packages/typescript-estree/src/convert.ts Outdated

		@@ -2342,6 +2362,7 @@ export class Converter {
		? this.convertType(node.constraint)
		: undefined,
		default: node.default ? this.convertType(node.default) : undefined,
		...this.convertTypeParamVariances(node.modifiers),

Copy link

Collaborator

armano2May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what do you think about changing it tohasModifier to be consistent with other use cases?

Suggested change

	...this.convertTypeParamVariances(node.modifiers),
	in:hasModifier(SyntaxKind.InKeyword,node)\|\|undefined,
	out:hasModifier(SyntaxKind.OutKeyword,node)\|\|undefined,

Copy link

Member

bradzacherMay 17, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

instead ofundefined - could we make itfalse?
I'd love for us to standardise on not emittingundefined for properties.
I personally don't like having 3 states on a flag - the keyword is either there, or it's not - there's no 3rd state!