Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree):extends constraints forinfer#4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzukisosukesuzuki commentedApr 17, 2022•
edited by bradzacher
Loading

PR Checklist

Overview

Based on#4829

According to TS Compiler AST, add theconstraints field to theTSTypeParameter, not theTSInferType. so This PR just adds tests(a87ec29 ).

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedApr 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit97a7626. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedApr 17, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit97a7626
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6283bb228f62810008d11a52
😎 Deploy Previewhttps://deploy-preview-4830--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@sosukesuzukisosukesuzuki changed the titlefeat:extends constraints forinferfeat(typescript-estree):extends constraints forinferApr 17, 2022
@bradzacherbradzacher added the ASTPRs and Issues about the AST structure labelApr 25, 2022
@bradzacher
Copy link
Member

i merged the version bump so this can be rebased on top of main

@sosukesuzukisosukesuzuki marked this pull request as ready for reviewMay 17, 2022 15:12
@codecov
Copy link

codecovbot commentedMay 17, 2022•
edited
Loading

Codecov Report

Merging#4830 (97a7626) intomain (f256357) willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4830      +/-   ##==========================================- Coverage   91.76%   91.75%   -0.01%==========================================  Files         229      227       -2       Lines       10635    10628       -7       Branches     3293     3293              ==========================================- Hits         9759     9752       -7  Misses        592      592                Partials      284      284
FlagCoverage Δ
unittest91.75% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/configs/strict.ts100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts
packages/visitor-keys/src/get-keys.ts

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is awesome that it was already supported!

@bradzacherbradzacher merged commit8cbbcc3 intotypescript-eslint:mainMay 17, 2022
@bradzacherbradzacher mentioned this pull requestMay 19, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
ASTPRs and Issues about the AST structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sosukesuzuki@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp