typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

Update comma-dangle.md#4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromZigaVukcevicDev:patch-1

Apr 16, 2022

Merged

Update comma-dangle.md#4827

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromZigaVukcevicDev:patch-1

Apr 16, 2022

Conversation

Copy link

Contributor

ZigaVukcevicDev commentedApr 15, 2022

Added note for 404 link.

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Update comma-dangle.md

7a646eb

Added note for 404 link.

Copy link

nx-cloudbot commentedApr 15, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2ce8e48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedApr 15, 2022

Thanks for the PR, @be-codified!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedApr 15, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`2ce8e48`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6259e1544a8a7100076cb382
😎 Deploy Preview	https://deploy-preview-4827--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher previously requested changes

Apr 15, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should instead just update the link to point at the correct URL.

Copy link

codecovbot commentedApr 15, 2022•
edited
Loading

Codecov Report

Merging#4827 (2ce8e48) intomain (18a81cb) willincrease coverage by0.28%.
The diff coverage is83.33%.

@@            Coverage Diff             @@##             main    #4827      +/-   ##==========================================+ Coverage   93.96%   94.24%   +0.28%==========================================  Files         172      151      -21       Lines        9818     8230    -1588       Branches     3105     2676     -429     ==========================================- Hits         9225     7756    -1469+ Misses        353      262      -91+ Partials      240      212      -28

Flag	Coverage Δ
unittest	`94.24% <83.33%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts	`80.64% <83.33%> (-2.05%)`	⬇️
...plugin-internal/src/rules/prefer-ast-types-enum.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
...-estree/src/create-program/createProjectProgram.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
packages/typescript-estree/src/ast-converter.ts
... and12 more

JoshuaKGoldberg requested changes

Apr 15, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, thanks for noticing this!

A more user-helpful fix would be to correct the link tohttps://eslint.org/docs/rules/comma-dangle. Could you do that instead please?

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Apr 15, 2022

ZigaVukcevicDev added2 commits

April 15, 2022 23:18

Update comma-dangle.md

376a93f

Added link.

Update comma-dangle.md

2ce8e48

Added anchor to the link.

Copy link

ContributorAuthor

ZigaVukcevicDev commentedApr 15, 2022

@JoshuaKGoldberg sure, I have also added anchor for options. Keep up the good work.

JoshuaKGoldberg approved these changes

Apr 16, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

JoshuaKGoldbergenabled auto-merge (squash)

April 16, 2022 01:46

JoshuaKGoldberg dismissedbradzacher’sstale review

April 16, 2022 01:46

old

JoshuaKGoldberg merged commit42ec8fd intotypescript-eslint:main

Apr 16, 2022

Copy link

Member

bradzacher commentedApr 16, 2022

@JoshuaKGoldberg dont forget to update the commit message before merging next time!

Copy link

Member

Josh-Cena commentedApr 16, 2022•
edited
Loading

GH quirk: if there are multiple commits in the branch, the squash-merge commit's message would take the PR title; otherwise, the commit message would be that single commit's message, disregarding the PR title. Regardless, I would recommend always normalizing the PR title as well.