I was initially working through all projects simultaneously but it became clear that reviewing the ultimate PR from that would be an absolute nightmare, so I am instead going to approach it project by project (with some follow on work to then optimize once all have been largely transitioned, e.g. by pulling code from source for tests to make them faster and no longer require a full build before running)

And sorry, specifically for scope-manager we have some noise for the generated code because of changing the instructions for regenerating them. This will not be the case for other projects

chore: refactor scope-manager config to be closer to nx OOTB

796c255

Copy link

nx-cloudbot commentedApr 4, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit7837ccf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedApr 4, 2022

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedApr 4, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`7837ccf`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/625162adff9b1a00099e819d
😎 Deploy Preview	https://deploy-preview-4788--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedApr 4, 2022•
edited
Loading

Codecov Report

Merging#4788 (7837ccf) intomain (4c428c5) willdecrease coverage by2.48%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4788      +/-   ##==========================================- Coverage   94.27%   91.78%   -2.49%==========================================  Files         151      226      +75       Lines        8220    10548    +2328       Branches     2672     3259     +587     ==========================================+ Hits         7749     9681    +1932- Misses        262      590     +328- Partials      209      277      +68

Flag	Coverage Δ
unittest	`91.78% <ø> (-2.49%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...estree/src/create-program/createIsolatedProgram.ts	`75.00% <0.00%> (ø)`
packages/type-utils/src/getDeclaration.ts	`0.00% <0.00%> (ø)`
packages/utils/src/ts-eslint-scope/Variable.ts	`100.00% <0.00%> (ø)`
packages/type-utils/src/typeFlagUtils.ts	`83.33% <0.00%> (ø)`
...s/utils/src/eslint-utils/batchedSingleLineTests.ts	`91.66% <0.00%> (ø)`
packages/utils/src/ts-eslint-scope/ScopeManager.ts	`100.00% <0.00%> (ø)`
...-estree/src/create-program/createProjectProgram.ts	`94.11% <0.00%> (ø)`
packages/type-utils/src/getTypeName.ts	`0.00% <0.00%> (ø)`
packages/utils/src/ast-utils/helpers.ts	`68.18% <0.00%> (ø)`
packages/typescript-estree/src/node-utils.ts	`98.29% <0.00%> (ø)`
... and65 more

JamesHenry marked this pull request as ready for review

April 4, 2022 09:52

JamesHenry requested review frombradzacher andJoshuaKGoldberg

April 4, 2022 09:52

JoshuaKGoldberg previously approved these changes

Apr 8, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm very unfamiliar with NX but reading through the docs and playing with this locally, it seems reasonable!

.eslintrc.js OutdatedShow resolvedHide resolved

packages/scope-manager/project.json OutdatedShow resolvedHide resolved

bradzacher reviewed

Apr 9, 2022

View reviewed changes

.eslintrc.js OutdatedShow resolvedHide resolved

jest.preset.jsShow resolvedHide resolved

packages/scope-manager/jest.config.jsShow resolvedHide resolved

packages/scope-manager/package.json OutdatedShow resolvedHide resolved

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Apr 9, 2022

JamesHenry added2 commits

April 9, 2022 14:21

Merge branch 'main' into scope-manager-nx

4e2d7b1

chore: implement pr feedback

7837ccf

JamesHenry dismissedJoshuaKGoldberg’sstale review via7837ccf

April 9, 2022 10:40

JamesHenry requested review frombradzacher andJoshuaKGoldberg

April 9, 2022 11:10

JoshuaKGoldberg approved these changes

Apr 10, 2022

View reviewed changes

Copy link

MemberAuthor

JamesHenry commentedApr 11, 2022•
edited
Loading

I'm just holding off on merging while I discuss the need for thecd ../../ in the aliases, it's not actually expected that those are necessary. I suspect it might have to do with our usage of the@typescript-eslint/ within the nx project names