Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): Contextual non-null [no-unnecessary-type-assertion]#478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
JamesHenry approved these changesMay 9, 2019
Codecov Report
@@ Coverage Diff @@## master #478 +/- ##==========================================- Coverage 95.88% 95.73% -0.15%========================================== Files 79 79 Lines 3571 3613 +42 Branches 998 1013 +15 ==========================================+ Hits 3424 3459 +35- Misses 51 53 +2- Partials 96 101 +5
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of "used before assigned" variables:
Fixes#453
Note: this fix isn't perfect, but it's "good enough".
The type checker exposes no mechanism to detect this case (but it has code for it:https://raw.githubusercontent.com/Microsoft/TypeScript/84076a55351684296f7b3f1d2715690acbe8039f/src/compiler/checker.ts and search for
Variable_0_is_used_before_being_assigned)See:microsoft/TypeScript#31124 andmicrosoft/TypeScript#20221
Also adds handling for contextually unnecessary non-null operator based on where it's used:
Will look at adding contextually unnecessary support to the
asbranch later - this PR is big enough as is...