Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: update babel alignment tests to latest version#4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomainfromtest/update-babel-tests
Apr 5, 2022

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedApr 2, 2022•
edited
Loading

PR Checklist

Overview

this change is required for merge of#4692

@nx-cloud
Copy link

nx-cloudbot commentedApr 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit37f2b03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedApr 2, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit37f2b03
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/62481253673e5200096ed0b6
😎 Deploy Previewhttps://deploy-preview-4774--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 added the testsanything to do with testing labelApr 2, 2022
@codecov
Copy link

codecovbot commentedApr 2, 2022•
edited
Loading

Codecov Report

Merging#4774 (37f2b03) intomain (c59d9d7) willdecrease coverage by0.31%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #4774      +/-   ##==========================================- Coverage   94.28%   93.97%   -0.32%==========================================  Files         151      172      +21       Lines        8208     9806    +1598       Branches     2670     3103     +433     ==========================================+ Hits         7739     9215    +1476- Misses        261      352      +91- Partials      208      239      +31
FlagCoverage Δ
unittest93.97% <ø> (-0.32%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...pt-estree/src/create-program/createWatchProgram.ts78.06% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts91.30% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts100.00% <0.00%> (ø)
...estree/src/create-program/createIsolatedProgram.ts75.00% <0.00%> (ø)
packages/typescript-estree/src/convert.ts98.39% <0.00%> (ø)
packages/typescript-estree/src/node-utils.ts98.29% <0.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts77.27% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts89.79% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts84.32% <0.00%> (ø)
packages/typescript-estree/src/convert-comments.ts100.00% <0.00%> (ø)
... and11 more

@armano2armano2 added the package: typescript-estreeIssues related to @typescript-eslint/typescript-estree labelApr 2, 2022
@@ -1,2 +1,2 @@
const x: X<never>;
var x: X<never>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For my learning: why the change?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

babel reports now errors for unidealized const variables, witch is tested in

    /**     * [BABEL ERRORED, BUT TS-ESTREE DID NOT]     * SyntaxError: Missing initializer in const declaration.     */    'var-with-definite-assignment',

JoshuaKGoldberg reacted with thumbs up emoji
Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love to see some of these ancient discrepancies have been resolved on the babel side 🎉

@bradzacherbradzacher merged commitde68e5e intomainApr 5, 2022
@armano2armano2 deleted the test/update-babel-tests branchApril 6, 2022 00:43
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
package: typescript-estreeIssues related to @typescript-eslint/typescript-estreetestsanything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@armano2@JamesHenry@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp