fix(website): correct dark mode color regression#4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfromchore/website-dark-mode-colors

Mar 31, 2022

Merged

fix(website): correct dark mode color regression#4771

bradzacher merged 1 commit intomainfromchore/website-dark-mode-colors

Mar 31, 2022

Conversation

Copy link

Collaborator

armano2 commentedMar 31, 2022•
edited
Loading

Overview

i noticed that dark mode colors are not workign correctly after changes done in#4362

html:root has higher priority thanhtml[data-theme='dark'] and it looks that dark mode overrides are no longer working correctly

and this should be

before fix:

after fix:

fix(website): correct dark mode color regression introduced in#4362

c73f7b1

armano2 added the package: websiteIssues related to the @typescript-eslint website label

Mar 31, 2022

Copy link

nx-cloudbot commentedMar 31, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc73f7b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 fromNxCloud.

This comment was marked as resolved.

Copy link

netlifybot commentedMar 31, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c73f7b1`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6246176d50979200093d1622
😎 Deploy Preview	https://deploy-preview-4771--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.